Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIAP: Allow pulling a private airshipctl binary repo #632

Closed
ian-howell opened this issue Sep 8, 2021 · 5 comments
Closed

AIAP: Allow pulling a private airshipctl binary repo #632

ian-howell opened this issue Sep 8, 2021 · 5 comments
Assignees
@sirajyasin
Labels
enhancement New feature or request priority/medium Default priority for items
Milestone
v2.1

Comments

@ian-howell
Copy link
Contributor

Problem description (if applicable)
We can pull airship manifests from a private repo, but that functionality doesn't currently exist for the binary repo itself.

Proposed change
Modify the artifact-setup container to implement authorization so that we can pull an airshipctl binary from a private repository
@ian-howell ian-howell added enhancement New feature or request triage Needs evaluation by project members labels Sep 8, 2021
@ian-howell ian-howell changed the title AIAP: Allow pulling the airshipctl binary from a private repository AIAP: Allow pulling a private airshipctl binary repo Sep 9, 2021
@sirajyasin
Copy link
Contributor

I can start working on this issue. Can someone assign this issue to me ?

@sreejithpunnapuzha
Copy link
Member

@sirajyasin all yours

@jezogwza jezogwza removed the triage Needs evaluation by project members label Sep 15, 2021
@jezogwza jezogwza added this to the v2.1 milestone Sep 15, 2021
@jezogwza jezogwza added the priority/medium Default priority for items label Sep 15, 2021
@sirajyasin
Copy link
Contributor

PS https://review.opendev.org/c/airship/airshipctl/+/809290 in review

airshipbot pushed a commit that referenced this issue Sep 28, 2021
@sirajyasin
Allow pulling from a private airshipctl repo
9070704 
* Added the logic to support pulling airshipctl from a
  private github repo with basic http authentication.

* Added Username, Password in secrets

Relates-To: #632
Relates-To: #636
Change-Id: If1a1bbfaf9ce543cf35377d367b70676f9e3e9ef
@sirajyasin
Copy link
Contributor

The related PS https://review.opendev.org/c/airship/airshipctl/+/809290 is merged. This issue can be marked completed

@eak13
Copy link

eak13 commented Sep 29, 2021

Closing per code merge

@eak13 eak13 closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirajyasin sirajyasin

Labels
enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
5 participants
@eak13 @jezogwza @ian-howell @sirajyasin @sreejithpunnapuzha