Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kustomize to the latest version #601

Closed
eak13 opened this issue Jul 12, 2021 · 6 comments
Closed

Upgrade Kustomize to the latest version #601

eak13 opened this issue Jul 12, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request priority/medium Default priority for items
Milestone

Comments

@eak13
Copy link

eak13 commented Jul 12, 2021

Problem description
In an effort to keep Airship current with the latest updates of its supporting components, upgrade Kustomize to the latest version (currently v4.2.0)

Kustomize information can be found here:

Proposed change

  • Upgrade Kustomize to v4.2.0
  • Validate Kustomize still functional & resolve any breaking changes
@eak13 eak13 added enhancement New feature or request triage Needs evaluation by project members labels Jul 12, 2021
@eak13 eak13 added this to the v2.1 milestone Jul 12, 2021
@aodinokov
Copy link

Here is what we can do:

The main issue with 4.1.3 and further (4.2.0) is that there will be conflicting dependencies.
I elaborated on that some time ago here. here is another PR https://review.opendev.org/c/airship/airshipctl/+/788582 that worked some time ago, but since we were not going in that direction it is in merge conflict now.

That means if we want to update only kustomize - we can update it only till 4.1.2, like it's done here:
https://review.opendev.org/c/airship/airshipctl/+/794269 . This PR is ready to be merged if needed.

if we want to keep up with the latest kustomize (which is a good idea for many reasons :) ), we can proceed in another way:
we need to get rid of ClusterApi dependency first by moving all clusterapi operations to krm-function (see Ruslan's PR: https://review.opendev.org/c/airship/airshipctl/+/793701 - it works already).
Once clusterApi disappears it will be possible to bump dependencies much more easily.

@eak13
Copy link
Author

eak13 commented Jul 12, 2021

Just to note, for patchset 793701, the corresponding issue is #568. Assuming we proceed that way, once merged & we close #568 then we can proceed with this issue.

@aodinokov
Copy link

@ak3216 , right... I've rebased 794269 on top of 793701 (made a separate PR: https://review.opendev.org/c/airship/airshipctl/+/800722 - it's in WIP, but looks like at least airshipctl can be compiled with new dependencies including kustomize)

@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Jul 14, 2021
@aodinokov
Copy link

https://review.opendev.org/c/airship/airshipctl/+/800722 is on top of 793701. it's complete and green. need to merge 793701, and rebase it and merge

@aodinokov
Copy link

aodinokov commented Jul 29, 2021

@ak3216 , done in https://review.opendev.org/c/airship/airshipctl/+/800722 . We have kustomize 4.2.0 now. Can be closed.

@aaronsheffield
Copy link

Closing based on the above merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Development

No branches or pull requests

4 participants