Add container cleanup to airship executor containers

[teoyaomiqui]

Problem description (if applicable)
When run phases that are built on top of GenericContainer executor with airship container as a back end, containers are never deleted.

At the time of implementation, this was intentionally left on the user to do, because of the simplified debugging. However now we need to make sure that there are no leftovers are running the container.

Proposed change

1. Add RmContainer() in the deferred function that runs the containers
2. Remove log message related to getting logs from the container, as the logs are printed to stderr anyway.

Potential impacts
It would be harder to debug in cased of failed containers.

[airshipbot]

Related Change #791811

Subject: Add airship container cleanup
Link: https://review.opendev.org/c/airship/airshipctl/+/791811
Status: NEW
Owner: Kostyantyn Kalynovskyi ([email protected])

This change will close this issue when merged.

Approvals

Code-Review
+1 Vladislav Kuzmin
+2 Ian Howell
+1 Sean Eagan
+1 Bijaya Sharma
Verified
+1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-05-24 14:02:56 CDT