Worker MachineTemplates are missing worker labels

[teoyaomiqui]

Describe the bug
Worker MachineTemplates missing labels to target workers:

https://github.com/airshipit/airshipctl/blob/master/manifests/site/test-site/target/workers/provision/metal3machinetemplate.yaml

Steps To Reproduce
Add multiple BMH hosts and add scale Worker MachineDeployment to more than one

Expected behavior
Only workers with appropriate label to be selected for the machines

Actual behavior
Cluster-API selects random BMH hosts for the k8s nodes.

Suggested solution

1. Change machine template to target nodes by worker label:

    spec:
      hostSelector:
        matchLabels:
          airshipit.org/k8s-role: worker

2. Modify BMH hosts generator to be label aware, add variables to specify labels per host in here:
   https://github.com/airshipit/airshipctl/blob/master/manifests/function/hostgenerator-m3/hosttemplate.yaml#L44

[airshipbot]

Related Change #786811

Subject: Add worker labels for the machine deployments
Link: https://review.opendev.org/c/airship/airshipctl/+/786811
Status: MERGED
Owner: Kostyantyn Kalynovskyi ([email protected])

Approvals

Code-Review
+2 Matt McEuen
+1 Andrii Ostapenko
+2 Drew Walters
+1 Vladislav Kuzmin
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-05-17 12:59:54 CDT

[jessegler]

I'm seeing a similar issue in Treasuremap, where if I render the machine template, the worker label is still missing.

[teoyaomiqui]

@jessegler Could you add a little more information about this? What is the site you are working on in TM also which phase are you rendering?

I am quite sure that the issue in TM will be solved as soon as we uplift airshipctl to the version that functionalizes worker provisioning here https://review.opendev.org/c/airship/airshipctl/+/778931

[jessegler]

@teoyaomiqui I looked into this a little more and found the root cause of what I'm seeing. manifests/site/test-site/target/workers/provision/kustomize.yaml isn't inheriting from airshipctl but rather sets the resources directly -- including the machine template.

It looks like that patchset should fix it. :)