Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several test sites in airshipctl manifests are outdated #503

Open
1 of 2 tasks
raliev12 opened this issue Mar 27, 2021 · 10 comments
Open
1 of 2 tasks

Several test sites in airshipctl manifests are outdated #503

raliev12 opened this issue Mar 27, 2021 · 10 comments
Labels
4-CI/CD Relates to issues with Zuul & gating bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size l
Milestone

Comments

@raliev12
Copy link
Contributor

raliev12 commented Mar 27, 2021

Describe the bug
We have several test sites in airshipctl manifests, but we have only one which configured and tested properly - test-site. Another ones, az-test-site, docker-test-site, gcp-test-site and openstack-test-site are outdated, we don't test them properly against our CI, we don't deploy them and they have misconfigured phase plans. The quick static validation of those test sites shows a lot of problems, like

  • improperly configured cluster-move phase without namespace
  • lack of cert-manager CRDs on cluster before running clusterctl-init-phase (which uses them)
    and so on.

Those sites require a lot of changes, fixes and adjustments to make them properly work.
Proposed solution:

  • Temporary disable mentioned test sites out of validate-site-docs job support since we can't maintain the same quality standards for test-site and another ones;
  • Once static validation based on kubeval embedded into validate-site-docs job, gradually enable az-test-site, docker-test-site, gcp-test-site and openstack-test-site back to validation support again. It might be helpful also to run check experimental zuul job with config file of appropriate site within appropriate patchsets to make sure it does work properly.

Steps To Reproduce
Deploy or validate of one the following test sites:

  • az
  • docker
  • gcp
  • openstack

Expected behavior
No issues during validation and deployment of the mentioned test sites.

@raliev12 raliev12 added bug Something isn't working triage Needs evaluation by project members labels Mar 27, 2021
@airshipbot
Copy link

airshipbot commented Mar 29, 2021

Related Change #780681

Subject: Add validation phases
Link: https://review.opendev.org/c/airship/airshipctl/+/780681
Status: MERGED
Owner: Ruslan Aliev ([email protected])

Approvals

Code-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-04-27 22:39:01 CDT

@rkjain
Copy link
Contributor

rkjain commented Mar 30, 2021

I can may be help test this out with docker and gcp

@jezogwza jezogwza added priority/critical Items critical to be implemented, usually by the next release and removed triage Needs evaluation by project members labels Apr 7, 2021
@jezogwza jezogwza added the 4-CI/CD Relates to issues with Zuul & gating label Apr 7, 2021
@jezogwza jezogwza added this to the v2.1 milestone Apr 7, 2021
@eak13
Copy link

eak13 commented Apr 14, 2021

@uberscott do you want to give this issue a shot? Thanks.

@uberscott
Copy link
Contributor

@ak3216 SURE! give it to me. Thank you!

@eak13
Copy link

eak13 commented Apr 14, 2021

@uberscott all yours! Thanks!

@sshiba
Copy link

sshiba commented Apr 24, 2021

I have update the scripts for az-test-site but cannot run gating in Zuul. See https://review.opendev.org/c/airship/airshipctl/+/787648.

Had plenty of time in between trying to deploy baremetal target cluster for testing Dex, so use the waiting time to multi-task.

Instead, I have updated the scripts to run in an "automated" fashion so the validate the deployment.
In the past we have created Jenkins pipeline for az-test-site, where Azure subscription credentials were save in Jenkins secrets.

airshipbot pushed a commit that referenced this issue Apr 28, 2021
This patch introduces ability to validate phases using kubeval.
Appropriate functionality was embedded into phase/plan validate
command.

Change-Id: I1e1ccae2b7e4948bdc97a199c96c07a3eb7292b2
Signed-off-by: Ruslan Aliev <[email protected]>
Relates-To: #503
Closes: #2
Closes: #19
@sshiba
Copy link

sshiba commented May 4, 2021

The scripts used to deploy az-test-site have been updated and validated through executing the scripts on a clean validation VM instantiated on Azure cloud.
https://review.opendev.org/c/airship/airshipctl/+/787648

Jenkins CI Pipeline for az-test-site deployment, which is used to automate the deployment of Target cluster on Azure cloud.
This pipeline uses the updated scripts in the above patchset.
https://review.gerrithub.io/c/att-comdev/cicd/+/515769

@airshipbot
Copy link

airshipbot commented May 4, 2021

Related Change #789640

Subject: Update Validation Logic for Clusterctl Move
Link: https://review.opendev.org/c/airship/airshipctl/+/789640
Status: MERGED
Owner: Ratnopam Chakrabarti ([email protected])

Approvals

Code-Review
+2 Kostyantyn Kalynovskyi
+2 Drew Walters
+1 Bijaya Sharma
+1 Matthew Fuller
+1 Deepak Kataria
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Drew Walters

Last Updated: 2021-05-25 23:19:01 CDT

@airshipbot
Copy link

airshipbot commented May 12, 2021

Related Change #790896

Subject: Update provider manifests for site validation
Link: https://review.opendev.org/c/airship/airshipctl/+/790896
Status: NEW
Owner: Ratnopam Chakrabarti ([email protected])

Approvals

Code-Review
! None
Verified
+1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None

Last Updated: 2021-05-26 13:38:59 CDT

airshipbot pushed a commit that referenced this issue May 26, 2021
Removed the namespace condition check from the validation of 'Move'.
This is to allow validation of docker and cloud provider test site
manifests that do not use namespace.

Relates-To: #503
Change-Id: I39544ba9c9c13ff5a6519b7afd8844629e60087e
@jezogwza jezogwza modified the milestones: v2.1, Future Jul 7, 2021
@jezogwza
Copy link
Contributor

jezogwza commented Jul 7, 2021

We need to focus on docker and azure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4-CI/CD Relates to issues with Zuul & gating bug Something isn't working priority/critical Items critical to be implemented, usually by the next release size l
Projects
None yet
Development

No branches or pull requests

7 participants