-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several test sites in airshipctl manifests are outdated #503
Comments
Related Change #780681Subject: Add validation phases ApprovalsCode-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi Last Updated: 2021-04-27 22:39:01 CDT |
I can may be help test this out with docker and gcp |
@uberscott do you want to give this issue a shot? Thanks. |
@ak3216 SURE! give it to me. Thank you! |
@uberscott all yours! Thanks! |
I have update the scripts for az-test-site but cannot run gating in Zuul. See https://review.opendev.org/c/airship/airshipctl/+/787648. Had plenty of time in between trying to deploy baremetal target cluster for testing Dex, so use the waiting time to multi-task. Instead, I have updated the scripts to run in an "automated" fashion so the validate the deployment. |
This patch introduces ability to validate phases using kubeval. Appropriate functionality was embedded into phase/plan validate command. Change-Id: I1e1ccae2b7e4948bdc97a199c96c07a3eb7292b2 Signed-off-by: Ruslan Aliev <[email protected]> Relates-To: #503 Closes: #2 Closes: #19
The scripts used to deploy az-test-site have been updated and validated through executing the scripts on a clean validation VM instantiated on Azure cloud. Jenkins CI Pipeline for az-test-site deployment, which is used to automate the deployment of Target cluster on Azure cloud. |
Related Change #789640Subject: Update Validation Logic for Clusterctl Move ApprovalsCode-Review
+2 Kostyantyn Kalynovskyi
+2 Drew Walters
+1 Bijaya Sharma
+1 Matthew Fuller
+1 Deepak Kataria
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Drew Walters Last Updated: 2021-05-25 23:19:01 CDT |
Related Change #790896Subject: Update provider manifests for site validation ApprovalsCode-Review
! None
Verified
+1 Zuul
+1 ATT Airship2.0 CI
Workflow
! None Last Updated: 2021-05-26 13:38:59 CDT |
Removed the namespace condition check from the validation of 'Move'. This is to allow validation of docker and cloud provider test site manifests that do not use namespace. Relates-To: #503 Change-Id: I39544ba9c9c13ff5a6519b7afd8844629e60087e
We need to focus on docker and azure. |
Describe the bug
We have several test sites in airshipctl manifests, but we have only one which configured and tested properly -
test-site
. Another ones,az-test-site
,docker-test-site
,gcp-test-site
andopenstack-test-site
are outdated, we don't test them properly against our CI, we don't deploy them and they have misconfigured phase plans. The quick static validation of those test sites shows a lot of problems, likecluster-move
phase without namespacecert-manager
CRDs on cluster before running clusterctl-init-phase (which uses them)and so on.
Those sites require a lot of changes, fixes and adjustments to make them properly work.
Proposed solution:
validate-site-docs
job support since we can't maintain the same quality standards fortest-site
and another ones;validate-site-docs
job, gradually enableaz-test-site
,docker-test-site
,gcp-test-site
andopenstack-test-site
back to validation support again. It might be helpful also to runcheck experimental
zuul job with config file of appropriate site within appropriate patchsets to make sure it does work properly.Steps To Reproduce
Deploy or validate of one the following test sites:
Expected behavior
No issues during validation and deployment of the mentioned test sites.
The text was updated successfully, but these errors were encountered: