Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign airship cluster status command #491

Open
lb4368 opened this issue Mar 17, 2021 · 3 comments
Open

Redesign airship cluster status command #491

lb4368 opened this issue Mar 17, 2021 · 3 comments
Labels
1-Core Relates to airshipctl core components (i.e. go code) design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items
Milestone

Comments

@lb4368
Copy link

lb4368 commented Mar 17, 2021

Problem description
The current airshipctl cluster status command needs to be redesigned for the current architecture of airshipctl taking into account phases and multiple clusters.

Proposed change
Need to revisit the airshipctl cluster status command design to determine it use in the current airshipctl architecture.

@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members design needed New Design or Redesign required labels Mar 17, 2021
@jezogwza jezogwza added this to the Future milestone Mar 24, 2021
@jezogwza jezogwza added 1-Core Relates to airshipctl core components (i.e. go code) priority/medium Default priority for items and removed triage Needs evaluation by project members labels Mar 24, 2021
@uberscott
Copy link
Contributor

@lb4368 I can take on this issue, although I may need a deeper explain of what is going on and how to fix.

@kozhukalov
Copy link
Contributor

It seems barely possible to implement this at the moment. Airship phase engine is stateless, we don't use any operator to deal with phases/phase plans. We don't deploy phase CRs anywhere. We also don't store phase run results/errors anywhere. A user who runs a phase plan can see which of the phases were successful and thus cluster status. But we can not have a separate command to gather the cluster status since we don't have such a place from where the status could be collected.

So, my suggestion is to close the issue as not feasible until we are going to use a stateful phase running mechanism.

@eak13
Copy link

eak13 commented Jul 7, 2021

@kozhukalov I'll add this to the design call agenda for Thursday 7/8 & we can discuss the path forward for this issue. Thanks for identifying the challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Core Relates to airshipctl core components (i.e. go code) design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items
Projects
None yet
Development

No branches or pull requests

5 participants