airshipctl document pull has a default pull from treasuremap that is not documented

[bravinash82]

Describe the bug
when "airshipctl document pull" is executed. Airshipctl automatically pulls/clones a default repository from treasuremap.

Steps To Reproduce
Execute "airshipctl document pull".

Expected behavior
Neither "https://docs.airshipit.org/airshipctl/cli/airshipctl_document_pull.html" nor the "airshipctl document pull --help" actually documents the fact that it does an automatic pull from treasumemap. Also should provide a mechanism to pull from non-default custom repository as well..

Environment

• airshipctl Version: v0.1.0 (from Master)
• Operating System: Ubuntu 20.04 LTS
• Kernel version: 5.4.0-48-generic
• Kubernetes Version: N/A
• Go version: go1.15.2 linux/amd64
• Hardware specs (e.g. 4 vCPUs, 16GB RAM, bare metal vs VM): VM (4 vCPU), 8GB RAM, 60GB HDD

[kozhukalov]

please, assign it to me

[sb1975]

Hope this helps - the url can be specified in the variable below :
: ${TREASUREMAP_PROJECT:="$(pwd)"}
which is referred below :
export AIRSHIP_CONFIG_PRIMARY_REPO_URL=${AIRSHIP_CONFIG_PRIMARY_REPO_URL:-"${TREASUREMAP_PROJECT}"}

https://github.com/airshipit/treasuremap/blob/v2/tools/deployment/22_test_configs.sh#L18

[kozhukalov]

https://review.opendev.org/c/airship/airshipctl/+/767571

[kozhukalov]

@bravinash82 could you please review the patch? Does it solve the issue?

[michaelfix]

@kozhukalov , @bravinash82 , what is the latest status? PS https://review.opendev.org/c/airship/airshipctl/+/767571 is pending core reviews and workflow. Needed for V2.0 which closes 3/30?

[lb4368]

This issue is dependent upon final design for #417.

[airshipbot]

Related Change #767571

Subject: Change default manifest target path
Link: https://review.opendev.org/c/airship/airshipctl/+/767571
Status: MERGED
Owner: Vladimir Kozhukalov ([email protected])

Approvals

Code-Review
+2 Matt McEuen
+2 Kostyantyn Kalynovskyi
Verified
+1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2021-05-06 16:59:09 CDT

[eak13]

Closing per patchset merge