Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define mechanism for managing lifecycle of Labels, Taints post deployment via BMH or provider artifacts #377

Closed
jezogwza opened this issue Oct 27, 2020 · 7 comments
Assignees
Labels
6-upstream/metal3-io Requires changes to upstream project, metal3-io enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size l
Milestone

Comments

@jezogwza
Copy link
Contributor

jezogwza commented Oct 27, 2020

The ability to update the BMH with some labels, that will be bubbled up to the Kubernetes nodes.

Watch for conflicts with CAPI managing labels, or other parties.
Might need to have specific prefixes to avoid race conditions.
Suggestion ... is using Prefix Labels. And then automatically appending the prefix to any label this manages,

This is likely an extension to capm3.

This might belong within the context of a CAPI provider infrastructure object mechanism.

@jezogwza jezogwza added enhancement New feature or request triage Needs evaluation by project members design needed New Design or Redesign required priority/critical Items critical to be implemented, usually by the next release labels Oct 27, 2020
@jezogwza jezogwza added this to the v2.0 milestone Oct 27, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Oct 27, 2020
@Arvinderpal
Copy link
Contributor

Ref metal3 issue: metal3-io/metal3-docs#146

@eak13
Copy link

eak13 commented Nov 4, 2020

this is different from #3 in that it's creating an operator independent of CAPI.

@Arvinderpal
Copy link
Contributor

@ak3216 We are working out the details of the design. The proposal in meta3 and discussion can be found here: metal3-io/metal3-docs#149

@eak13 eak13 added the 6-upstream/metal3-io Requires changes to upstream project, metal3-io label Jan 12, 2021
@Arvinderpal
Copy link
Contributor

Update on this:
The design doc ready to merge. Waiting on lazy consensus by end of this week: metal3-io/metal3-docs#149
The PR for the feature is also under review: metal3-io/cluster-api-provider-metal3#152

@Arvinderpal
Copy link
Contributor

Update: The design proposal was accepted and merged. The feature PR is currently under review.

@eak13 eak13 added the size l label Mar 1, 2021
@lb4368 lb4368 modified the milestones: v2.0, v2.1 Mar 18, 2021
@Arvinderpal
Copy link
Contributor

This feature has landed in capm3: metal3-io/cluster-api-provider-metal3#152

@lb4368 lb4368 modified the milestones: v2.1, Future Apr 26, 2021
@eak13
Copy link

eak13 commented Aug 17, 2021

Closing per above.

@eak13 eak13 closed this as completed Aug 17, 2021
@eak13 eak13 modified the milestones: Future, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-upstream/metal3-io Requires changes to upstream project, metal3-io enhancement New feature or request priority/critical Items critical to be implemented, usually by the next release size l
Projects
None yet
Development

No branches or pull requests

4 participants