Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] fix download calibrated file functionality for calibrate tool #1492

Merged
merged 2 commits into from
Sep 13, 2023
Merged

[Hotfix] fix download calibrated file functionality for calibrate tool #1492

merged 2 commits into from
Sep 13, 2023

Conversation

Codebmk
Copy link
Member

@Codebmk Codebmk commented Sep 13, 2023 •
edited by jira bot
Loading

Summary of Changes (What does this PR do?)

  • fix download calibrated file functionality for calibrate tool
  • Unable to test with staging but works with production api

Status of maturity (all need to be checked before merging):

  • I've tested this in production(staging api is returning 504 error)
  • I consider this code done
  • This change ready to hit production in its current state

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Screenshot from 2023-09-13 13-36-15

@Codebmk Codebmk self-assigned this Sep 13, 2023
@github-actions
Copy link
Contributor

New calibrate app changes available for preview here

Baalmart
Baalmart approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Codebmk

@Baalmart Baalmart merged commit 91ce4a1 into staging Sep 13, 2023
23 checks passed
@Baalmart Baalmart deleted the calibration-hotfix branch September 13, 2023 11:17
@Baalmart Baalmart mentioned this pull request Sep 13, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

Assignees

@Codebmk Codebmk

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codebmk @Baalmart