Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use SGD with sparse matrix #90

Open
jeffwong-nflx opened this issue Nov 24, 2016 · 5 comments
Open

Cannot use SGD with sparse matrix #90

jeffwong-nflx opened this issue Nov 24, 2016 · 5 comments

Comments

@jeffwong-nflx
Copy link

Hi, great package! I noticed that you can only use the sgd(x = ..., y = ...) interface if x is either a big matrix or a matrix, but not a sparse matrix as in the result of sparse.model.matrix. This support would be great

@ptoulis
Copy link
Contributor

ptoulis commented Nov 24, 2016

thanks Jeff! Indeed, working on sparse models is a priority.

@jeffwong-nflx
Copy link
Author

Since you are using RcppArmadillo, the equivalent class would be a arma::sp_mat instead of arma::mat. Is it just a matter of changing the Rcpp interfaces ? If so I could help with that

@ptoulis
Copy link
Contributor

ptoulis commented Nov 24, 2016

@dustinvtran would this change interfere with any changes you are currently implementing?

@dselivanov
Copy link

Duplicate #85

@dustinvtran
Copy link
Member

apologies for the (very) delayed response; from a cursory glance it would be as simple as changing those classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants