fix: properly template extraEnv values #874
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebye
changed the title
|
@thesuperzapper Hey, sorry to bother, but would you be able to give this a look? We're currently maintaining a separate fork just for this reason. |
jessebye
changed the title
|
@jessebye please don't cut a release in this PR, only make template changes. Also, we might want to include a small blurb about this in our docs (which live in markdown files on this repo): |
2 tasks
Signed-off-by: Jesse Bye <[email protected]> Signed-off-by: jessebye <[email protected]>
|
@thesuperzapper Ok, did a quick rebase and updated the documentation to mention use of templating in |
|
@thesuperzapper next steps? Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
#879
What does your PR do?
Runs
extraEnvvalues throughtplso users can utilize templating in their values.Checklist
For all Pull Requests
For releasing ONLY