Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set Service protocol field (for istio support) #545

Closed
4 tasks done
thesuperzapper opened this issue Mar 22, 2022 · 0 comments · Fixed by #854
Closed
4 tasks done

Automatically set Service protocol field (for istio support) #545

thesuperzapper opened this issue Mar 22, 2022 · 0 comments · Fixed by #854
Labels
kind/enhancement kind - new features or changes
Milestone

Comments

@thesuperzapper
Copy link
Member

Checks

Motivation

A number of issues have been raised about the names we use for service ports, not being compatible with istio requirements:

Implementation

Rather than allowing users to rename ports (as proposed in #493), and potentially specify the wrong protocol, we can automatically specify the protocol field of ContainerPort v1 (added in K8S 1.18), by detecting if AIRFLOW__WEBSERVER__WEB_SERVER_SSL_CERT and AIRFLOW__WEBSERVER__WEB_SERVER_SSL_KEY are set with detection similar to our define "airflow.web.scheme", which is used in the webserver probe.

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@thesuperzapper thesuperzapper added the kind/enhancement kind - new features or changes label Mar 22, 2022
@thesuperzapper thesuperzapper changed the title Automatically set Service protocol field (for istio support) Automatically set Service protocol field (for istio support) Mar 22, 2022
@thesuperzapper thesuperzapper added this to the airflow-8.7.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes
Projects
Development

Successfully merging a pull request may close this issue.

1 participant