Service Port Naming Not Compatible with Istio

[dansc0de]

What is the bug?

pgbouncer, worker, and web have static service port names that are incompatible with Istio naming conventions.

Note: I have a PR to address it

What version of the chart are you using?

I am using version 8.5.2 of this chart.

What version of Kubernetes are you using?

Client Version: Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-05-12T14:18:45Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"darwin/amd64"}

Server Version: Server Version: version.Info{Major:"1", Minor:"21+", GitVersion:"v1.21.2-eks-0389ca3", GitCommit:"8a4e27b9d88142bbdd21b997b532eb6d493df6d2", GitTreeState:"clean", BuildDate:"2021-07-31T01:34:46Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"linux/amd64"}

What version of Helm are you using?

version.BuildInfo{Version:"v3.5.4", GitCommit:"1b5edb69df3d3a08df77c9902dc17af864ff05d1", GitTreeState:"dirty", GoVersion:"go1.16.3"}

What are your custom helm values?

click to expand

######## PASTE values.yaml BELOW ########
airflow:
  airflow:
    config:
      AIRFLOW__LOGGING__REMOTE_BASE_LOG_FOLDER: "s3://bucket/airflow-test"
      AIRFLOW__WEBSERVER__BASE_URL: "https://xxx.example.dev"

      ENV: staging
  dags:
    gitSync:
      branch: "staging"
  ingress:
    web:
      host: "xxx.example.dev"
  workers:
    replicas: 2
  postgresql:
    persistence:
      size: 20Gi
      existingClaim: existing-claim-
  serviceAccount:
    annotations:
      eks.amazonaws.com/role-arn: "arn:aws:iam::1234567890:role/this-role"
  ...
######## PASTE values.yaml ABOVE ########

[thesuperzapper]

@danattatari As I raised in #510 (comment), I think we should instead be dynamically setting the protocol field of ContainerPort v1 (added in K8S 1.18) based off if the AIRFLOW__WEBSERVER__WEB_SERVER_SSL_CERT and AIRFLOW__WEBSERVER__WEB_SERVER_SSL_KEYconfigs are set.

[thesuperzapper]

I am closing this issue in preference of using #545 to discuss the implementation of the automatic soution.