Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace constructors in stream transfer manager helper with a builder #13253

Merged
merged 1 commit into from
May 28, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented May 27, 2022

What

@github-actions github-actions bot added the area/connectors Connector related issues label May 27, 2022
@tuliren tuliren requested a review from edgao May 27, 2022 03:15
@tuliren tuliren mentioned this pull request May 27, 2022
2 tasks
@tuliren
Copy link
Contributor Author

tuliren commented May 28, 2022

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/2399697159
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/2399697159
No Python unittests run

Build Passed

Test summary info:

All Passed

@tuliren
Copy link
Contributor Author

tuliren commented May 28, 2022

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/2399697800
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/2399697800
No Python unittests run

Build Passed

Test summary info:

All Passed

@tuliren
Copy link
Contributor Author

tuliren commented May 28, 2022

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2399698891
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/2399698891
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

@tuliren
Copy link
Contributor Author

tuliren commented May 28, 2022

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2399699195
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/2399699195
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 13      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    13      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     155      8    95%
normalization/transform_config/transform.py                         159     31    81%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_catalog/utils.py                             38      9    76%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 543    352    35%
-------------------------------------------------------------------------------------
TOTAL                                                              1333    559    58%

Build Passed

Test summary info:

All Passed

@tuliren tuliren merged commit e65a97a into master May 28, 2022
@tuliren tuliren deleted the liren/clean-up-stream-transfer-manager-helper branch May 28, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GCS destination
2 participants