Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the comment step in test and publish commands to the front #13238

Merged
merged 1 commit into from
May 26, 2022
Merged

Move the comment step in test and publish commands to the front #13238

merged 1 commit into from
May 26, 2022

Conversation

tuliren
Copy link
Contributor

@tuliren tuliren commented May 26, 2022 •
edited
Loading

What

  • In this way, we can get a link to the action if when one of the early steps fails (e.g. Set up Cloud SDK).

@tuliren tuliren requested a review from evantahler May 26, 2022 20:18
@tuliren
Copy link
Contributor Author

tuliren commented May 26, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql

❌ Failed to publish connectors/source-mssql
❌ Couldn't auto-bump version for connectors/source-mssql

evantahler
evantahler approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. And I also like the timely usage of our publish problem to test that this works 🔼 😄

@tuliren tuliren temporarily deployed to more-secrets May 26, 2022 20:19 Inactive
@tuliren
Copy link
Contributor Author

tuliren commented May 26, 2022

Unfortunate it does not work before this PR is merged. In the action pipeline, the link comment step is still further down the line:
https://github.com/airbytehq/airbyte/runs/6616038216?check_suite_focus=true

Strange that changes to the pipeline somethings work in the PR, and sometimes do not.

@tuliren tuliren merged commit 60f78a9 into master May 26, 2022
@tuliren tuliren deleted the liren/move-comment-step-to-the-front branch May 26, 2022 20:25
@tuliren
Copy link
Contributor Author

tuliren commented May 26, 2022

Proof that it works: #13176 (comment)

jscottpolevault pushed a commit to jscottpolevault/airbyte that referenced this pull request Jun 1, 2022
@tuliren
Move the comment step in test and publish commands to the front (airb…
ad7a276 
…ytehq#13238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuliren @evantahler