Source Amazon Seller Partner: OAuth support #13119

annalvova05 · 2022-05-24T10:55:00Z

What

Add OAuth2.0 authorization.

How

Implement OAuth java part and update spec.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…-sp-oauth

…-sp-oauth # Conflicts: # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/__init__.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py # airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json # airbyte-integrations/connectors/source-amazon-seller-partner/unit_tests/test_source.py # airbyte-scheduler/persistence/src/test/java/io/airbyte/scheduler/persistence/DefaultJobPersistenceTest.java

…-sp-docs # Conflicts: # docs/integrations/sources/amazon-seller-partner.md

annalvova05 · 2022-05-24T15:25:57Z

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2378868895
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2378868895
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           22      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      37      1    97%
source_amazon_seller_partner/source.py         49     10    80%
source_amazon_seller_partner/streams.py       365    169    54%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         536    216    60%

midavadim

This update can be merged without airbyte review

…-sp-docs

…-sp-oauth

…p-oauth

annalvova05 · 2022-05-30T12:41:53Z

/test connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2409114288
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2409114288
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                        Stmts   Miss  Cover
---------------------------------------------------------------
source_amazon_seller_partner/spec.py           22      0   100%
source_amazon_seller_partner/__init__.py        2      0   100%
source_amazon_seller_partner/constants.py      37      1    97%
source_amazon_seller_partner/source.py         49     10    80%
source_amazon_seller_partner/streams.py       365    169    54%
source_amazon_seller_partner/auth.py           61     36    41%
---------------------------------------------------------------
TOTAL                                         536    216    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestBasicRead.test_read because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 17 passed, 3 skipped in 5.94s =========================

codecov · 2022-05-30T12:46:59Z

Codecov Report

❗ No coverage uploaded for pull request base (master@9d1cd42). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6a48a74 differs from pull request most recent head 6eb06fa. Consider uploading reports for the commit 6eb06fa to get more accurate results

@@            Coverage Diff            @@
##             master   #13119   +/-   ##
=========================================
  Coverage          ?   59.70%           
=========================================
  Files             ?        6           
  Lines             ?      536           
  Branches          ?        0           
=========================================
  Hits              ?      320           
  Misses            ?      216           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1cd42...6eb06fa. Read the comment docs.

annalvova05 · 2022-05-30T13:02:16Z

/publish connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2409214205
🚀 Successfully published connectors/source-amazon-seller-partner
🚀 Auto-bumped version for connectors/source-amazon-seller-partner
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/2409214205

…irbyte into alvova/11963-amazon-sp-oauth

* Update docs * add oauth * add spec.py * test * fix * fix * add lwa_app_id * test * test * fix * add beta version * fix * test * test * test * merge * fix * fix * fix * test * test * test * test * sort AWSRegion * up * add import * up * up * up * fix * fix tests * bump version * upd * auto-bump connector version * format Co-authored-by: Octavia Squidington III <[email protected]>

annalvova05 added 24 commits May 5, 2022 12:53

Update docs

727e222

add oauth

5b6a360

add spec.py

6a46588

Merge remote-tracking branch 'origin/master' into alvova/11963-amazon…

d966557

…-sp-oauth

test

d0cea31

fix

e977ad3

fix

d79229a

add lwa_app_id

07a8f3b

test

ebe1172

test

594da5f

fix

171820f

add beta version

36580c2

fix

f2c0c37

test

3790e8c

test

03dfe7c

test

91dece4

merge

a5530ad

fix

97d82f8

fix

69b16f4

fix

8939185

test

59b1dd5

test

b7a87d8

test

1cca7ff

github-actions bot added the area/connectors Connector related issues label May 24, 2022

test

4e50755

annalvova05 temporarily deployed to more-secrets May 24, 2022 11:18 Inactive

sort AWSRegion

a71f106

annalvova05 temporarily deployed to more-secrets May 24, 2022 11:24 Inactive

up

b06693e

github-actions bot added the area/documentation Improvements or additions to documentation label May 24, 2022

annalvova05 temporarily deployed to more-secrets May 24, 2022 15:04 Inactive

annalvova05 added 2 commits May 24, 2022 18:22

upd

95c4aaf

Merge remote-tracking branch 'origin/master' into alvova/11964-amazon…

93b4318

…-sp-docs # Conflicts: # docs/integrations/sources/amazon-seller-partner.md

annalvova05 marked this pull request as ready for review May 24, 2022 15:38

annalvova05 requested a review from lazebnyi May 24, 2022 15:38

lazebnyi approved these changes May 26, 2022

View reviewed changes

annalvova05 requested a review from midavadim May 26, 2022 13:31

midavadim approved these changes May 27, 2022

View reviewed changes

annalvova05 added 3 commits May 30, 2022 15:16

Merge remote-tracking branch 'origin/master' into alvova/11964-amazon…

9919453

…-sp-docs

Merge remote-tracking branch 'origin/master' into alvova/11963-amazon…

8495300

…-sp-oauth

Merge branch 'alvova/11964-amazon-sp-docs' into alvova/11963-amazon-s…

257c77a

…p-oauth

annalvova05 temporarily deployed to more-secrets May 30, 2022 12:43 Inactive

auto-bump connector version

6a48a74

octavia-squidington-iii temporarily deployed to more-secrets May 30, 2022 13:19 Inactive

annalvova05 added 2 commits May 30, 2022 16:22

format

a530383

Merge branch 'alvova/11963-amazon-sp-oauth' of github.com:airbytehq/a…

6eb06fa

…irbyte into alvova/11963-amazon-sp-oauth

annalvova05 merged commit 1dbd7ab into master May 30, 2022

annalvova05 deleted the alvova/11963-amazon-sp-oauth branch May 30, 2022 13:24

annalvova05 mentioned this pull request May 30, 2022

Source Amazon Seller Partner: update docs #12603

Closed

14 tasks

annalvova05 temporarily deployed to more-secrets May 30, 2022 13:25 Inactive

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Amazon Seller Partner: OAuth support #13119

Source Amazon Seller Partner: OAuth support #13119

annalvova05 commented May 24, 2022 •

edited

Loading

annalvova05 commented May 24, 2022 •

edited by github-actions bot

Loading

midavadim left a comment

annalvova05 commented May 30, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 30, 2022 •

edited

Loading

annalvova05 commented May 30, 2022 •

edited by github-actions bot

Loading

Source Amazon Seller Partner: OAuth support #13119

Source Amazon Seller Partner: OAuth support #13119

Conversation

annalvova05 commented May 24, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

annalvova05 commented May 24, 2022 • edited by github-actions bot Loading

midavadim left a comment

Choose a reason for hiding this comment

annalvova05 commented May 30, 2022 • edited by github-actions bot Loading

Build Passed

codecov bot commented May 30, 2022 • edited Loading

Codecov Report

annalvova05 commented May 30, 2022 • edited by github-actions bot Loading

annalvova05 commented May 24, 2022 •

edited

Loading

annalvova05 commented May 24, 2022 •

edited by github-actions bot

Loading

annalvova05 commented May 30, 2022 •

edited by github-actions bot

Loading

codecov bot commented May 30, 2022 •

edited

Loading

annalvova05 commented May 30, 2022 •

edited by github-actions bot

Loading