Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customer_id as the user_id in segment in the webapp. #1256

Closed
cgardens opened this issue Dec 9, 2020 · 0 comments · Fixed by #1268
Closed

Use customer_id as the user_id in segment in the webapp. #1256

cgardens opened this issue Dec 9, 2020 · 0 comments · Fixed by #1268
Assignees
Labels
priority/high High priority type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Dec 9, 2020

When we call identify in the webapp, we are currently letting segment set the user id itself. We are then adding customer_id as an attribute on that user. Instead we want to user the customer_id provided by the API as the user id.

Current code:

      AnalyticsService.identify({
        customerId: workspace.customerId
      });

https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/pages/routes.tsx#L142
Desired:

      AnalyticsService.identify({}, workspace.customerId);

I was trying to do this myself, but was having trouble sanity checking that it was working in the Segment debugger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high High priority type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants