Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust data type & schema permutations testing in Destination Acceptance Tests #8862

Closed
sherifnada opened this issue Dec 17, 2021 · 4 comments
Assignees
Labels
area/connectors Connector related issues area/warehouses type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

DAT provides some good guarantees that a destination works as intended. However, it does not do a thorough verification that any data type expressable via JsonSchema can be written to a destination. For example, we've had some issues recently related to data types and schema declarations in JsonSchema:

  1. Json -> Avro / Parquet schema convert should support array field without items #7939 valid json schema declaration which failed in destination s3
  2. 🎉 Destination S3 & GCS: support additional properties #7288 valid json schema declaration which failed in destination s3
  3. NullPointerException while sync when source-s3 CSV -> destination-s3 PARQUET #6871 valid json schema declaration which failed in destination s3

Describe the solution you’d like

I would like to test all possible combinations of valid json schema declarations in DAT so that we can proactively verify that destinations can handle data coming from sources, rather than play whack-a-mole.

@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues area/warehouses labels Dec 17, 2021
@sherifnada sherifnada added this to the ConnCore Jan 5 milestone Dec 22, 2021
@sherifnada
Copy link
Contributor Author

relevant: https://docs.airbyte.io/understanding-airbyte/json-avro-conversion#untyped-array
example of something not currently covered in the type system: #8280

potential steps:

  1. defining the subset of JSONSchema that all destinations should be able to support
  2. coding it into DAT

@edgao
Copy link
Contributor

edgao commented Dec 27, 2021

self notes:

@sherifnada
Copy link
Contributor Author

goals for this week:

  • wrap up design
  • create project plan

@sherifnada
Copy link
Contributor Author

tech spec was created, epic here: https://github.com/airbytehq/airbyte-internal-issues/issues/371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/warehouses type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants