Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery locations update #8816

Merged
merged 3 commits into from
Dec 16, 2021
Merged

BigQuery locations update #8816

merged 3 commits into from
Dec 16, 2021

Conversation

ChristopheDuong
Copy link
Contributor

@ChristopheDuong ChristopheDuong commented Dec 15, 2021 •
edited
Loading

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 15, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets December 15, 2021 17:49 Inactive
@ChristopheDuong ChristopheDuong force-pushed the chris/bq-locations-update branch from e7d9a9c to 7e5b067 Compare December 15, 2021 17:50
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets December 15, 2021 17:51 Inactive
@marcosmarxm
Copy link
Member

@ChristopheDuong can you update from bigquery-denormalized too?

@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets December 15, 2021 18:05 Inactive
marcosmarxm
marcosmarxm approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@marcosmarxm
Copy link
Member

Don't forget to run ./gradlew airbyte-config:init:processResources and bump the config files version

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Dec 15, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1584198113
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1584198113

@ChristopheDuong
Copy link
Contributor Author

ChristopheDuong commented Dec 15, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1584198564
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1584198564

@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 18:54 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 18:54 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 16, 2021
@ChristopheDuong ChristopheDuong temporarily deployed to more-secrets December 16, 2021 09:30 Inactive
@ChristopheDuong ChristopheDuong merged commit 3740f25 into master Dec 16, 2021
@ChristopheDuong ChristopheDuong deleted the chris/bq-locations-update branch December 16, 2021 09:48
@jrhizor jrhizor mentioned this pull request Dec 17, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@ChristopheDuong @schlattk
BigQuery locations update (airbytehq#8816)
b1c7a11 
* Update bigquery dataset locations

* Update BQ denormalized locations too

* Bumpversion bq destinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

@Phlair Phlair Awaiting requested review from Phlair

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery connectors/destination/bigquery-denormalized connectors/destinations-warehouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristopheDuong @marcosmarxm @jrhizor @karinakuz