Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery/BiqQuery denorm Destinations : Add possibility to use different types of GCS files #8788

Merged
merged 58 commits into from
Dec 20, 2021

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented Dec 14, 2021

What

Decrease complexity of the BigQuery destinations and add possibility to load data using Avro GCS.

How

Reorganize current implementation to use different implementation instead of code duplication.
Make Avro file loader in line with BigQuery loader.
Reorganize JsonSchema flow in order to generate BigQuery schema and Avro file schema using already modified schema.

Recommended reading order

  1. AbstractBigQueryUploader.java
  2. BigQueryRecordFormatter.java
  3. BigQueryDirectUploader.java
  4. BigQueryTableWriter.java
  5. CommonWriter.java
  6. GcsAvroWriter.java
  7. GcsAvroBigQueryUploader.java
  8. DefaultBigQueryDenormalizedRecordFormatter.java
  9. GcsBigQueryDenormalizedRecordFormatter.java
  10. BigQueryDenormalizedDestination.java

@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets December 14, 2021 15:59 Inactive
@github-actions github-actions bot removed area/worker Related to worker area/platform issues related to the platform labels Dec 14, 2021
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets December 14, 2021 21:57 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets December 15, 2021 12:44 Inactive
@DoNotPanicUA DoNotPanicUA temporarily deployed to more-secrets December 15, 2021 21:49 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets December 20, 2021 13:54 Inactive
@alexandr-shegeda
Copy link
Contributor

alexandr-shegeda commented Dec 20, 2021

/test connector=destination-bigquery

🕑 destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1602453679
✅ destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1602453679
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@alexandr-shegeda
Copy link
Contributor

alexandr-shegeda commented Dec 20, 2021

/test connector=destination-bigquery-denormalized

🕑 destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1602454626
✅ destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1602454626
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 14:22 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 14:22 Inactive
@sherifnada
Copy link
Contributor

sherifnada commented Dec 20, 2021

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1602905932
✅ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1602905932

@sherifnada sherifnada temporarily deployed to more-secrets December 20, 2021 16:08 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 16:08 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 16:08 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 20, 2021 16:09 Inactive
@alexandr-shegeda alexandr-shegeda merged commit 637fac3 into master Dec 20, 2021
@alexandr-shegeda alexandr-shegeda deleted the aleonets/oncall27-bigq branch December 20, 2021 17:00
@alexandr-shegeda
Copy link
Contributor

alexandr-shegeda commented Dec 21, 2021

/publish connector=connectors/destination-bigquery

Error: No ref found for: aleonets/oncall27-bigq

@alexandr-shegeda alexandr-shegeda restored the aleonets/oncall27-bigq branch December 21, 2021 12:36
@alexandr-shegeda
Copy link
Contributor

alexandr-shegeda commented Dec 21, 2021

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1606794585
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1606794585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants