Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Facebook Marketing does not resolve refs correctly #7725

Closed
sherifnada opened this issue Nov 8, 2021 · 1 comment · Fixed by #7734
Closed

Source Facebook Marketing does not resolve refs correctly #7725

sherifnada opened this issue Nov 8, 2021 · 1 comment · Fixed by #7734

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Nov 8, 2021

Current Behavior

If I run python main.py discover --config secrets/config.json inside facebook marketing connector, I see the output contains a lot of $refs. The output from discover should not contain any refs, as the rest of the Airbyte platform does not support this directive.

Expected Behavior

refs should be expanded in-line before being output from discover

This is potentially related to #6638

@sherifnada
Copy link
Contributor Author

sherifnada commented Nov 8, 2021

Actually after some investigation, this is definitely related to the issue #6638. The catalog output by Facebook marketing contains a lot of $refs which are not resolvable at the moment within airbyte. the connector should resolve all internally and present a complete, unreferenced schema as the output from discover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants