Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop logging request bodies for imports #5900

Closed
jrhizor opened this issue Sep 7, 2021 · 0 comments
Closed

stop logging request bodies for imports #5900

jrhizor opened this issue Sep 7, 2021 · 0 comments
Assignees
@benmoriceau
Labels
accepting-contributions Feel free to contribute to them priority/high High priority type/bug Something isn't working
Milestone
Platform 2021-10-20

Comments

@jrhizor
Copy link
Contributor

jrhizor commented Sep 7, 2021

See a recent run with an example of logging the binary from /api/v1/deployment/import.

It looks like the isContentTypeGzip check in RequestLogger isn't working all of the time.
@jrhizor jrhizor added type/bug Something isn't working priority/medium Medium priority cloud-public-launch labels Sep 7, 2021
@jrhizor jrhizor changed the title stop import calls from logging stop logging request bodies for imports Sep 7, 2021
@jrhizor jrhizor added priority/high High priority accepting-contributions Feel free to contribute to them and removed priority/medium Medium priority cloud-public-launch labels Oct 1, 2021
@benmoriceau benmoriceau self-assigned this Oct 13, 2021
@benmoriceau benmoriceau mentioned this issue Oct 13, 2021
Merged
@cgardens cgardens added this to the Platform 2021-10-20 milestone Oct 13, 2021
@jrhizor jrhizor closed this as completed Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benmoriceau benmoriceau

Labels
accepting-contributions Feel free to contribute to them priority/high High priority type/bug Something isn't working
Projects
None yet
Milestone
Platform 2021-10-20
Development

No branches or pull requests
3 participants
@jrhizor @benmoriceau @cgardens