Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workspace-wide setting to toggle if pre-sync checks run and prevent syncs #12285

Closed
Tracked by #12119
evantahler opened this issue Apr 22, 2022 · 1 comment
Closed
Tracked by #12119

Comments

@evantahler
Copy link
Contributor

evantahler commented Apr 22, 2022

After #12281 we will be running the CHECK (both Source and Destination) command before every sync. We could add an option to disable this.

@evantahler
Copy link
Contributor Author

evantahler commented Apr 25, 2022

Closing this issue. As CHECKs are fast (~15s or shorter), we don't want to add more confusion for our users by introducing a new (workspace-wide) setting.

If checks become even slower, we can revisit this choice.

cc @sherifnada @misteryeo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant