Use bundleForClass: instead of mainBundle for framework compatibility #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why this PR is till here. LGTM |
jocelynlih
added a commit
that referenced
this pull request
Oct 17, 2015
Use bundleForClass: instead of mainBundle for framework compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Airbrake as a framework,
[[NSBundle mainBundle] pathForResource:@"ABNotifier" ofType:@"bundle"]inABLocalizedStringwill returnnil. To support frameworks and static libraries, this should be changed to[[NSBundle bundleForClass:[ABNotifier class]] pathForResource:@"ABNotifier" ofType:@"bundle"]or something similar.In the current implementation, there is an assertion failure and crash when building notice alerts.
There is quite a bit more information in the Pod Authors Guide to CocoaPods Frameworks from the CocoaPods folks that may be helpful.