[hotfix] delete DAR when datasource requested does not exist anymore (#…

…2040)
apache · Jan 25, 2017 · 5715f52 · 5715f52
1 parent 1f2126f
commit 5715f52
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/superset/source_registry.py b/superset/source_registry.py
@@ -20,7 +20,7 @@ def get_datasource(cls, datasource_type, datasource_id, session):
         return (
             session.query(cls.sources[datasource_type])
             .filter_by(id=datasource_id)
-            .one()
+            .first()
         )
 
     @classmethod

diff --git a/superset/views.py b/superset/views.py
@@ -1295,7 +1295,9 @@ def clean_fulfilled_requests(session):
                 datasource = SourceRegistry.get_datasource(
                     r.datasource_type, r.datasource_id, session)
                 user = sm.get_user_by_id(r.created_by_fk)
-                if self.datasource_access(datasource, user):
+                if not datasource or \
+                   self.datasource_access(datasource, user):
+                    # datasource doesnot exist anymore
                     session.delete(r)
             session.commit()
         datasource_type = request.args.get('datasource_type')