[hotfix] not grouped by -2

apache · Feb 26, 2017 · 10ea635 · 10ea635
1 parent 55e462d
commit 10ea635
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/superset/assets/package.json b/superset/assets/package.json
@@ -1,6 +1,6 @@
 {
   "name": "superset",
-  "version": "0.16.1rc3",
+  "version": "0.16.1rc4",
   "description": "Superset is a data exploration platform designed to be visual, intuitive, and interactive.",
   "license": "Apache-2.0",
   "directories": {

diff --git a/superset/assets/visualizations/table.js b/superset/assets/visualizations/table.js
@@ -19,14 +19,13 @@ function tableVis(slice, payload) {
   const fd = slice.formData;
   // Removing metrics (aggregates) that are strings
   const realMetrics = [];
-  if (fd.metrics) {
-    for (const k in data.records[0]) {
-      if (fd.metrics.indexOf(k) > -1 && !isNaN(data.records[0][k])) {
-        realMetrics.push(k);
-      }
+  let metrics = fd.metrics || [];
+  for (const k in data.records[0]) {
+    if (metrics.indexOf(k) > -1 && !isNaN(data.records[0][k])) {
+      realMetrics.push(k);
     }
   }
-  const metrics = realMetrics;
+  metrics = realMetrics;
 
   function col(c) {
     const arr = [];
@@ -145,8 +144,8 @@ function tableVis(slice, payload) {
   fixDataTableBodyHeight(
       container.find('.dataTables_wrapper'), height);
   // Sorting table by main column
-  if (fd.metrics.length > 0) {
-    const mainMetric = fd.metrics[0];
+  if (metrics.length > 0) {
+    const mainMetric = metrics[0];
     datatable.column(data.columns.indexOf(mainMetric)).order('desc').draw();
   }
   container.parents('.widget').find('.tooltip').remove();