Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-picks: A few small fixes (slice width) + pivot table #107

Merged
merged 7 commits into from
Sep 12, 2018

Conversation

kristw
Copy link

@kristw kristw commented Sep 12, 2018

Cherry-pick the following commit(s):

SHA Time Log Author
bec0b4c Wed Sep 12 12:32:46 2018 -0700 [tests] fix sqllab/TableElement_spec (apache#5874) Chris Williams
367dcda Wed Sep 12 11:21:48 2018 -0700 [time table] fix sorting on missing values (apache#5863) Maxime Beauchemin
166058d Wed Sep 12 10:05:39 2018 -0700 correctly compute slice width in dashboard (apache#5867) Krist Wongsuphasawat
962eb08 Tue Sep 11 16:57:11 2018 -0700 fix Object.assign try to write to read-only option.style (apache#5860) Krist Wongsuphasawat
3f8b970 Thu Sep 6 21:48:41 2018 -0700 [bugfix] Fix bignumber overflow in dashboard (apache#5839) Krist Wongsuphasawat
5eff7a8 Wed Sep 5 14:14:12 2018 -0700 [SIP-5] Refactor pivot table (apache#5705) Krist Wongsuphasawat

Verified on devbox with production data

@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster

kristw and others added 7 commits September 12, 2018 14:26
* Move BigNumber to directory.

* fix chart margin in dashboard

* Fix margin and be more conservative about width.

(cherry picked from commit 3f8b970)
* extract slice and formData

* rename variables

* update proptypes and add comments

(cherry picked from commit 5eff7a8)
@kristw kristw changed the title [WIP] Cherry-pick(s): <description> Cherry-picks: A few small fixes (slice width) + pivot table Sep 12, 2018
@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #107 into airbnb-master will decrease coverage by 0.03%.
The diff coverage is 2.63%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master     #107      +/-   ##
=================================================
- Coverage          63.45%   63.42%   -0.04%     
=================================================
  Files                356      356              
  Lines              22156    22168      +12     
  Branches            2496     2498       +2     
=================================================
  Hits               14059    14059              
- Misses              8085     8097      +12     
  Partials              12       12
Impacted Files Coverage Δ
...ashboard/components/gridComponents/ChartHolder.jsx 93.18% <ø> (ø) ⬆️
.../assets/src/visualizations/BigNumber/BigNumber.jsx 0% <0%> (ø)
superset/assets/src/visualizations/pivot_table.js 0% <0%> (ø) ⬆️
superset/assets/src/visualizations/time_table.jsx 0% <0%> (ø) ⬆️
.../assets/src/components/VirtualizedRendererWrap.jsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345d233...b9dfd18. Read the comment docs.

@kristw kristw merged commit 9bb4086 into airbnb:airbnb-master Sep 12, 2018
@kristw kristw deleted the kristw-cherry-sep12 branch September 20, 2018 21:52
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants