Feat: Enable warnings when values are overwritten in registries (#107)

* enable warning * add warning * fix order
airbnb · Nov 26, 2021 · 0f5e88e · 0f5e88e
1 parent 11378a4
commit 0f5e88e
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 11 deletions.
diff --git a/...superset-ui/packages/superset-ui-chart/src/registries/ChartBuildQueryRegistrySingleton.ts b/...superset-ui/packages/superset-ui-chart/src/registries/ChartBuildQueryRegistrySingleton.ts
@@ -1,8 +1,8 @@
-import { Registry, makeSingleton } from '@superset-ui/core';
+import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
 
 class ChartBuildQueryRegistry extends Registry {
   constructor() {
-    super({ name: 'ChartBuildQuery' });
+    super({ name: 'ChartBuildQuery', overwritePolicy: OverwritePolicy.WARN });
   }
 }
 

diff --git a/.../superset-ui/packages/superset-ui-chart/src/registries/ChartComponentRegistrySingleton.ts b/.../superset-ui/packages/superset-ui-chart/src/registries/ChartComponentRegistrySingleton.ts
@@ -1,8 +1,8 @@
-import { Registry, makeSingleton } from '@superset-ui/core';
+import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
 
 class ChartComponentRegistry extends Registry {
   constructor() {
-    super({ name: 'ChartComponent' });
+    super({ name: 'ChartComponent', overwritePolicy: OverwritePolicy.WARN });
   }
 }
 

diff --git a/...i/superset-ui/packages/superset-ui-chart/src/registries/ChartMetadataRegistrySingleton.ts b/...i/superset-ui/packages/superset-ui-chart/src/registries/ChartMetadataRegistrySingleton.ts
@@ -1,8 +1,8 @@
-import { Registry, makeSingleton } from '@superset-ui/core';
+import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
 
 class ChartMetadataRegistry extends Registry {
   constructor() {
-    super({ name: 'ChartMetadata' });
+    super({ name: 'ChartMetadata', overwritePolicy: OverwritePolicy.WARN });
   }
 }
 

diff --git a/...rset-ui/packages/superset-ui-chart/src/registries/ChartTransformPropsRegistrySingleton.ts b/...rset-ui/packages/superset-ui-chart/src/registries/ChartTransformPropsRegistrySingleton.ts
@@ -1,8 +1,8 @@
-import { Registry, makeSingleton } from '@superset-ui/core';
+import { Registry, makeSingleton, OverwritePolicy } from '@superset-ui/core';
 
 class ChartTransformPropsRegistry extends Registry {
   constructor() {
-    super({ name: 'ChartTransformProps' });
+    super({ name: 'ChartTransformProps', overwritePolicy: OverwritePolicy.WARN });
   }
 }
 

diff --git a/...d/temporary_superset_ui/superset-ui/packages/superset-ui-color/src/ColorSchemeRegistry.ts b/...d/temporary_superset_ui/superset-ui/packages/superset-ui-color/src/ColorSchemeRegistry.ts
@@ -1,9 +1,10 @@
-import { RegistryWithDefaultKey } from '@superset-ui/core';
+import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
 
 export default class ColorSchemeRegistry<T> extends RegistryWithDefaultKey<T> {
   constructor() {
     super({
       name: 'ColorScheme',
+      overwritePolicy: OverwritePolicy.WARN,
       setFirstItemAsDefault: true,
     });
   }

diff --git a/...superset_ui/superset-ui/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts b/...superset_ui/superset-ui/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts
@@ -1,4 +1,4 @@
-import { RegistryWithDefaultKey } from '@superset-ui/core';
+import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
 import createD3NumberFormatter from './factories/createD3NumberFormatter';
 import NumberFormats from './NumberFormats';
 import NumberFormatter from './NumberFormatter';
@@ -11,6 +11,7 @@ export default class NumberFormatterRegistry extends RegistryWithDefaultKey<
     super({
       initialDefaultKey: NumberFormats.SI,
       name: 'NumberFormatter',
+      overwritePolicy: OverwritePolicy.WARN,
     });
   }
 

diff --git a/...ary_superset_ui/superset-ui/packages/superset-ui-time-format/src/TimeFormatterRegistry.ts b/...ary_superset_ui/superset-ui/packages/superset-ui-time-format/src/TimeFormatterRegistry.ts
@@ -1,4 +1,4 @@
-import { RegistryWithDefaultKey } from '@superset-ui/core';
+import { RegistryWithDefaultKey, OverwritePolicy } from '@superset-ui/core';
 import TimeFormats, { LOCAL_PREFIX } from './TimeFormats';
 import createD3TimeFormatter from './factories/createD3TimeFormatter';
 import TimeFormatter from './TimeFormatter';
@@ -11,6 +11,7 @@ export default class TimeFormatterRegistry extends RegistryWithDefaultKey<
     super({
       initialDefaultKey: TimeFormats.DATABASE_DATETIME,
       name: 'TimeFormatter',
+      overwritePolicy: OverwritePolicy.WARN,
     });
   }