[slider] Fix RTL support #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes airbnb#282 Signed-off-by: Richard Gregory <[email protected]>
a15n
reviewed
Jan 12, 2023
| @@ -532,7 +532,7 @@ class Rheostat extends React.Component { | |||
| } | |||
| const horizontalPercentage = ((x - sliderBox.left) / sliderBox.width) * PERCENT_FULL; | |||
| if (direction === DIRECTIONS.RTL) { | |||
| return 100 - horizontalPercentage; | |||
| return horizontalPercentage; | |||
There was a problem hiding this comment.
I don't think this change is correct. If so the horizontalPercentage is the same in RTL and LTR. The bigger issue is that react-with-direction is not auto-flipping the left/right CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282
Signed-off-by: Richard Gregory [email protected]