Support Android LiteMode #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good! Can you squash the commits first? There's 18 of them, with a lot of merge commits. cc: @felipecsl to look at Android code. |
| @@ -44,8 +44,11 @@ | |||
|
|
|||
| private final ReactApplicationContext appContext; | |||
|
|
|||
| protected GoogleMapOptions googleMapOptions; | |||
There was a problem hiding this comment.
can't be final as AirMapLiteManager overrides it
|
android code lgtm after the 2 comments are addressed |
|
Should we add an example for |
Great idea! Let's add that before merging. |
|
Adding Examples now |
|
Added docs and examples |
|
Can someone take another quick look? I guess it's kind of ready to get in? |
|
tried the example, looks good :) 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion #300