-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped google-play-things in build.gradle to 9.+ #533
Conversation
Would this cause issues for apps that still need AFAIK, that version number is a minimum, meaning that cc: @felipecsl |
From my usage when different node_modules have different play versions it causes issues. In other words 8.4.0 doesn't seem to be a minimum, and causes app crash. See #452 #420 . This will cause issues with modules that are using 8.4.0, but I guess from the Compatibility line in the readme, I would assume we would want to strictly use the latest versions of google-play things unless there was a conflict with react-native-maps itself? |
You can keep it at 8.4.0 as i dont think there are any specific features from 9.x that are used This will cause a white map btw , i can confirm. |
Is it common for users not to upgrade their play services? I can't seem to find any statistics about this. Also, while keeping it at 8.4.0 will support older devices, it will cause crashes for modules that use newer versions of google play services. This means that modules that do use features from 9.x will be incompatible with react-native-maps. |
I'd definitely recommend bumping to v9 |
Why not update to latest version - 9.4.0? |
Sounds good. @felipecsl, our resident Android expert, is recommending that. (Thanks for bearing with my ignorance about Android 😸 .) @i8wu can you update the PR? |
Updated |
👍 |
Thanks! |
Just published 0.8.1 that includes this change. |
It turns out 0.8.1 was faulty, because my working directory had an additional example app containing the |
Guys we lost support for older devices by upgrading to 9+ though. |
@rops why is that? Are there any devices that are not compatible with GPS v9? |
You would get this nice alert on a device running Android 19 :(
|
yeah that sucks but you should always be able to update your GPS and eventually if you don't, most apps will stop working 😢 |
Can you update GPS without doing a full OS upgrade? |
I think so. AFAIK GPS upgrades are not tied to OS version. I scanned through the release notes and didn't find anythink mentioning that in the v9 release changes |
You can download latest version of GPS anytime from Play Market and it's a common thing. |
It seems my users with older versions of Google Play Services did not get the MapView display, but got a gray view with an "Update" button. When pressing the update button, my app crashes. If the user updates Play Services from the Play Store the MapView renders fine. Is there something in the MapView that needs to be caught? |
Bumping build.gradle to use latest version of google-play, should fix crashing when conflicting with other node modules that use the 9.+ version