-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide invisible first month using visibility: hidden
#940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the animation still work as expected? Or do you need to add a visibility
to the transition list (i'm not sure where that styling is set)?
@backwardok yeah so this is in the |
0721387
to
6ccee38
Compare
@backwardok @erin-doyle @ljharb can you take another look? The effect here is that both the first and last month (which are off-screen) are hidden from the nav. However, both have visibility during animation (otherwise things get weird). Thoughts? |
Reasonable to me - I'll let someone else stamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems legit.
any possibility of a regression test? no worries if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fix for #939
FYI @erin-doyle @backwardok