Remove startDateId and endDateId default prop values

[majapw]

Fix for #326

The ids were made required but their default prop values were not removed and as such the required aspect was useless. This addresses that issue.

This is technically breaking.

to: @ljharb @erin-doyle @airbnb/webinfra

[coveralls]

Coverage remained the same at 86.571% when pulling 1789935 on maja-make-drp-ids-required into e0d96f6 on master.

[ljharb]

@majapw why is this breaking? If the props are required, then the defaultProp was never needed.

We definitely shouldn't worry about someone who was ignoring propType warnings.

[majapw]

@ljharb the props have been required for a while, but because default props were also provided, then people wouldn't see an error when not using their own ids. if we remove the default props, then people who were previously not seeing an error will now see one. that was my motivation for marking it as breaking.

[ljharb]

Hmm, I guess that's technically breaking, but I also think people ignoring propType warnings are OK to break :-p

[JcBernack]

None of the documentation is updated to reflect this change, it still says "required: no". Also I can't find documentation what startDateId and endDateId actually even do or why I would want to set them. In the readme they are listed under OPTIONAL props (note the caps).

but because default props were also provided, then people wouldn't see an error when not using their own ids

Noone was ignoring an error, because there never was one. Removing the defaultProp absolutely was a breaking change. /rant 😉

[erin-doyle]

It looks like we have a few propType warnings when running the tests now. Not a big deal but kind of annoying:

Warning: Failed prop type: The prop `startDateId` is marked as required in `withStyles(DateRangePicker)`, but its value is `undefined`.
    in withStyles(DateRangePicker)
Warning: Failed prop type: The prop `endDateId` is marked as required in `withStyles(DateRangePicker)`, but its value is `undefined`.
    in withStyles(DateRangePicker)
Warning: Failed prop type: The prop `startDateId` is marked as required in `DateRangePicker`, but its value is `undefined`.
    in DateRangePicker
Warning: Failed prop type: The prop `endDateId` is marked as required in `DateRangePicker`, but its value is `undefined`.
    in DateRangePicker

[ljharb]

Fair enough, my bad.

@majapw, should we revert this and publish a v16.0.2, and then rerevert it for a v17?

[majapw]

That seems reasonable to me! It'd be good to add a blurb about the id as well in the README. I am sans computer for ten days so would appreciate if you did that @ljharb. Sorry for the warnings!

…

On Fri, Dec 15, 2017, 11:12 AM Jordan Harband ***@***.***> wrote: Fair enough, my bad. @majapw <https://github.com/majapw>, should we revert this and publish a v16.0.2, and then rerevert it for a v17? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#866 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUdtVoxxG4RHFLxwqOtKptOyPVgPJYDks5tAqiAgaJpZM4QuXjl> .

[ljharb]

No prob, I'll take care of it today (revert + publish + put up rerevert PR)

[ljharb]

Whoops, this is actually in v15. I'll revert it in v15.5.2 tonight/tomorrow, but leave it in v16 (and add the docs).

[ljharb]

v15.5.2 v15.5.3 is published; i'll follow up with a docs PR for v16 when I can.