add verticalHeight prop for DayPicker #773
Conversation
|
Changes Unknown when pulling 12f1479 on ingiulio:daypicker_vertical_height into ** on airbnb:master**. |
ingiulio
force-pushed
the
daypicker_vertical_height
branch
from
12f1479 to
ef1e9d0
Compare
|
Changes Unknown when pulling ef1e9d0 on ingiulio:daypicker_vertical_height into ** on airbnb:master**. |
src/components/DayPicker.jsx
Outdated
| @@ -55,6 +55,7 @@ const propTypes = forbidExtraProps({ | |||
| hideKeyboardShortcutsPanel: PropTypes.bool, | |||
| daySize: nonNegativeInteger, | |||
| isRTL: PropTypes.bool, | |||
| verticalHeight: PropTypes.number, | |||
There was a problem hiding this comment.
should this be a nonNegativeInteger?
There was a problem hiding this comment.
sounds good, I can't think of a case where it would in fact make sense to use a negative height 🤔
|
@majapw ok! I'll add it there too. Btw, is the |
|
@ingiulio try rebasing on the latest master, on the command line? |
ingiulio
force-pushed
the
daypicker_vertical_height
branch
from
ef1e9d0 to
6698278
Compare
ingiulio
force-pushed
the
daypicker_vertical_height
branch
from
6698278 to
b0eac7b
Compare
|
This PR will be ready to go once you can set the I also reran the pending test. |
ingiulio
force-pushed
the
daypicker_vertical_height
branch
from
b0eac7b to
81912e9
Compare
|
Done, thank you! |
There was a problem hiding this comment.
I think more examples is always a great idea! :) If we were to add a visual diffing tool like https://github.com/Galooshi/happo or something, every example we've already written would add that much more. I'm pretty happy with this.
Could you also add verticalHeight: nonNegativeInteger to the DateRangePickerShape and SingleDatePickerShape files? :)
After that, I'll merge this in. :)
ingiulio
force-pushed
the
daypicker_vertical_height
branch
from
81912e9 to
a3964c2
Compare
majapw
force-pushed
the
daypicker_vertical_height
branch
from
a3964c2 to
8e222a7
Compare
majapw
force-pushed
the
daypicker_vertical_height
branch
from
8e222a7 to
fb1a15b
Compare
|
Thank you! :) |
Addresses #632
👋
These changes allow the user of DayPicker to specify a vertical height (applied only when on vertical orientation), while keeping the current behavior (an arbitrary size) as the default if no height is specified.
This is actually slightly different than what the issue's title suggests, but imho it seems easier for the user to just have full control on the height rather than trying different "factors". Open to different opinions obviously!