Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove minimumNights prop from DayPickerSingleDateController #686

Merged
merged 2 commits into from
Aug 24, 2017
Merged

Remove minimumNights prop from DayPickerSingleDateController #686

merged 2 commits into from
Aug 24, 2017

Conversation

toddkblake
Copy link

@toddkblake toddkblake commented Aug 24, 2017 •
edited
Loading

Resolves issue #685

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.49% when pulling 72a7dd2 on toddkblake:fix-error-minimum-nights-prop-type into e330839 on airbnb:master.

ljharb
ljharb requested changes Aug 24, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually; can you remove its usage from the storybook examples too?

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Aug 24, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.49% when pulling 82975c6 on toddkblake:fix-error-minimum-nights-prop-type into e330839 on airbnb:master.

@ljharb ljharb merged commit bea3c2c into react-dates:master Aug 24, 2017
This was referenced Aug 24, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddkblake @coveralls @ljharb