Be able to highlight day #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
approved these changes
Dec 13, 2016
majapw
reviewed
Dec 13, 2016
| @@ -10,6 +10,7 @@ $react-dates-color-primary-shade-1: #33dacd !default; | |||
| $react-dates-color-primary-shade-2: #66e2da !default; | |||
| $react-dates-color-primary-shade-3: #80e8e0 !default; | |||
| $react-dates-color-primary-shade-4: #b2f1ec !default; | |||
| $react-dates-color-primary-shade-5: #ffe8bc !default; | |||
There was a problem hiding this comment.
I think since this isn't a shade of react-dates-color-primary we should name this react-dates-color-highlighted
|
would really love this feature. could this feature be merged into master in the foreseeable future? |
|
As soon as the comments are addressed, I think we can move forward. |
|
Sorry for late response. Here is a screenshot for it! |
|
Awesome! Looks great to me. :D Can you rebase squash the commits down into 1 @sideroad? I'll merge it in after that! 👍 |
|
Hi @sideroad! Instead of pressing the |
sideroad
force-pushed
the
highlighted_day
branch
from
f810a9c to
fa565ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be able to specify highlight day.
Currently, I specified yellow color as highlighted.
If there is any better color, Plz let me know.
#36