Adds a prop that keeps the DayPicker open when you select a date #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm thanks! |
ljharb
reviewed
Nov 2, 2016
| @@ -47,6 +47,7 @@ const defaultProps = { | |||
| disabled: false, | |||
| required: false, | |||
| reopenPickerOnClearDates: false, | |||
| keepOpen: false, | |||
ljharb
requested changes
Nov 2, 2016
| @@ -70,12 +70,17 @@ storiesOf('SingleDatePicker', module) | |||
| showClearDate | |||
| /> | |||
| )) | |||
| .add('with clear dates button (Picker Displayed)', () => ( | |||
| .add('eopens DayPicker on clear dates', () => ( | |||
majapw
force-pushed
the
maja-dont-autoclose-the-datepicker
branch
from
649f8da to
cec8f48
Compare
|
Addressed comments! PTAL @ljharb |
majapw
force-pushed
the
maja-dont-autoclose-the-datepicker
branch
from
cec8f48 to
a435fb2
Compare
ljharb
approved these changes
Nov 2, 2016
majapw
force-pushed
the
maja-dont-autoclose-the-datepicker
branch
from
a435fb2 to
44ba968
Compare
|
This also fixes #62 |
…he DRP or the SDP
majapw
force-pushed
the
maja-dont-autoclose-the-datepicker
branch
from
44ba968 to
e578253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @moonboots @airbnb/webinfra
The prop needs a better name. Also this needs tests. But I'm literally dying.
However, this behavior was pretty easy to implement so that's cool.