Allow DateRangePickerInput border theme to be overriden #1201
Conversation
| borderColor: color.border, | ||
| borderWidth: border.pickerInput.borderWidth, | ||
| borderStyle: border.pickerInput.borderStyle, | ||
| borderRadius: border.pickerInput.borderRadius, |
There was a problem hiding this comment.
Maybe this is not needed? Not sure
There was a problem hiding this comment.
def is. thank you for doing it in both pickers!
| @@ -296,8 +296,10 @@ export default withStyles(({ reactDates: { color, sizing } }) => ({ | |||
| }, | |||
|
|
|||
| DateRangePickerInput__withBorder: { | |||
| border: `1px solid ${color.border}`, | |||
There was a problem hiding this comment.
minor; but changing border might be a breaking change for those overriding it with CSS
There was a problem hiding this comment.
I thought in the most recent version of react-dates the classNames are scrambled, no?
There was a problem hiding this comment.
with the aphrodite interface sure, but i'm not sure about with the css interface
There was a problem hiding this comment.
I think anyone overriding the border will see the same effect they did before, so I'm not concerned.
majapw
force-pushed
the
me--allow-date-picker-theme-overrides
branch
from
a2c64bb to
4e37ae0
Compare
| @@ -296,8 +296,10 @@ export default withStyles(({ reactDates: { color, sizing } }) => ({ | |||
| }, | |||
|
|
|||
| DateRangePickerInput__withBorder: { | |||
| border: `1px solid ${color.border}`, | |||
There was a problem hiding this comment.
I think anyone overriding the border will see the same effect they did before, so I'm not concerned.
| borderColor: color.border, | ||
| borderWidth: border.pickerInput.borderWidth, | ||
| borderStyle: border.pickerInput.borderStyle, | ||
| borderRadius: border.pickerInput.borderRadius, |
There was a problem hiding this comment.
def is. thank you for doing it in both pickers!
|
awesome, thanks @majapw |
No description provided.