Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion trails since 4.3.0 #2200

Closed
AlasdairWem opened this issue Sep 27, 2023 · 6 comments · Fixed by #2202
Closed

Motion trails since 4.3.0 #2200

AlasdairWem opened this issue Sep 27, 2023 · 6 comments · Fixed by #2202

Comments

@AlasdairWem
Copy link

AlasdairWem commented Sep 27, 2023

Hi all 👋

We've noticed lagging/trails/tracing on the dots in this animation when they move together after full pin entry.
The animation is two separate Lotties cycling from one to the other.
The problem *becomes noticeable here: ecdadec
Our configuration of the view is unaltered.

Which Version of Lottie are you using?

4.3.2

Expected Behavior

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-09-27.at.12.02.13.mp4

Actual Behavior

notExpected.mp4

Animation JSON

stageThreeBottomToTop.json.zip

@calda
Copy link
Member

calda commented Sep 27, 2023

Can you please share a sample project that demonstrates this issue? When I test the stageThreeBottomTopTop animation locally I don't see any unexpected trails or artifacts.

@AlasdairWem
Copy link
Author

Hey, thanks for the quick reply. One extra bit of info, we're actually cycling between two animations here, this is the other one. I wonder if jumping from one to the other is causing the problem.
I'll get a demo project setup asap 👍

@AlasdairWem
Copy link
Author

AlasdairWem commented Sep 28, 2023

On closer inspection, my suspicion is that the animation/layer isn't removed as quickly as it was previously on completion, hence showing a trace of the old when the new begins. Perhaps there's something we can do to work around this?

Able to reproduce in the project attached -

lottieBugReproduction.zip

@calda
Copy link
Member

calda commented Sep 28, 2023

Thank you very much for the sample project! Much appreciated.

Here's a fix: #2202

@AlasdairWem
Copy link
Author

🎉 Thanks so much! Really appreciate it 🙏

@calda
Copy link
Member

calda commented Sep 28, 2023

I'll release 4.3.3 as soon as the fix is merged

cgrindel-self-hosted-renovate bot referenced this issue in cgrindel/rules_swift_package_manager Sep 30, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.3.2"` -> `from: "4.3.3"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.3.3`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.3.3)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.2...4.3.3)

**Lottie 4.3.0** adds many new features, including:

-   Official support for SwiftUI!
-   A public Core Animation `CALayer` subclass
-   Support for reduced motion
-   Support for drop shadow layer effects
-   Support for visionOS

You can learn more about Lottie 4.3.0 in this announcement: **[Lottie
4.3.0 now available, with official support for SwiftUI
#&#8203;2189](https://togithub.com/airbnb/lottie-ios/discussions/2189)**

Lottie 4.3.3 fixes a regression introduced by Lottie 4.3.0 where the
contents of a `LottieAnimationView` could crossfade / animate
unexpectedly when updating the current `LottieAnimation` or rendering
engine:
[https://github.com/airbnb/lottie-ios/issues/2200](https://togithub.com/airbnb/lottie-ios/issues/2200)

#### New Features in Lottie 4.3.0

-   Add SwiftUI `LottieView`, which wraps UIKit `LottieAnimationView`
- Add SwiftUI `LottieSwitch`, which wraps UIKit `AnimatedSwitch`
([https://github.com/airbnb/lottie-ios/pull/2138](https://togithub.com/airbnb/lottie-ios/pull/2138))
- Add SwiftUI `LottieButton`, which wraps `AnimatedButton`
([https://github.com/airbnb/lottie-ios/pull/2139](https://togithub.com/airbnb/lottie-ios/pull/2139))
- `AnimatedSwitch` and `AnimatedButton` now support macOS
([https://github.com/airbnb/lottie-ios/pull/2138](https://togithub.com/airbnb/lottie-ios/pull/2138),
[https://github.com/airbnb/lottie-ios/pull/2139](https://togithub.com/airbnb/lottie-ios/pull/2139))
- Add `LottieAnimationLayer`, a Core Animation `CALayer` subclass for
playing Lottie animations
([https://github.com/airbnb/lottie-ios/pull/2073](https://togithub.com/airbnb/lottie-ios/pull/2073))
- Add support for rendering drop shadow layer effects
([https://github.com/airbnb/lottie-ios/pull/2142](https://togithub.com/airbnb/lottie-ios/pull/2142))
- Add API for playing multiple markers sequentially
([https://github.com/airbnb/lottie-ios/pull/2084](https://togithub.com/airbnb/lottie-ios/pull/2084))
- Play "reduced motion" marker if
`UIAccessibility.isReduceMotionEnabled` is true
([https://github.com/airbnb/lottie-ios/pull/2110](https://togithub.com/airbnb/lottie-ios/pull/2110))
- Update text provider API to use full `AnimationKeypath` values
([https://github.com/airbnb/lottie-ios/pull/2183](https://togithub.com/airbnb/lottie-ios/pull/2183))
- Add support for visionOS
([https://github.com/airbnb/lottie-ios/pull/2152](https://togithub.com/airbnb/lottie-ios/pull/2152))
- Drop support for Swift 5.5
([https://github.com/airbnb/lottie-ios/pull/2152](https://togithub.com/airbnb/lottie-ios/pull/2152))
- Add contents gravity configuration to `AnimationImageProvider`
([https://github.com/airbnb/lottie-ios/pull/2177](https://togithub.com/airbnb/lottie-ios/pull/2177))
- Add support for customizing stroke width values using
`FloatValueProvider`
([https://github.com/airbnb/lottie-ios/pull/2179](https://togithub.com/airbnb/lottie-ios/pull/2179))
- Adopt `Sendable` to support using Lottie with strict concurrency
enabled
([https://github.com/airbnb/lottie-ios/pull/2126](https://togithub.com/airbnb/lottie-ios/pull/2126))
- Add `LottiePlaybackMode` to support declarative playback configuration
([https://github.com/airbnb/lottie-ios/pull/2128](https://togithub.com/airbnb/lottie-ios/pull/2128))
- Add option make main thread rendering engine force display update on
every frame
([https://github.com/airbnb/lottie-ios/pull/2168](https://togithub.com/airbnb/lottie-ios/pull/2168))
- Add a option to prevent caching images from `AnimationImageProvider`
([https://github.com/airbnb/lottie-ios/pull/2171](https://togithub.com/airbnb/lottie-ios/pull/2171))
- Add support for customizing gradient values using
`GradientValueProvider`
([https://github.com/airbnb/lottie-ios/pull/2182](https://togithub.com/airbnb/lottie-ios/pull/2182))
- Added additional support for multiple animations in `DotLottieFile`
([https://github.com/airbnb/lottie-ios/pull/2074](https://togithub.com/airbnb/lottie-ios/pull/2074))
- Add helper method to initialize `DotLottieFile` with data
([https://github.com/airbnb/lottie-ios/pull/2090](https://togithub.com/airbnb/lottie-ios/pull/2090))

#### Bug fixes

- Remove `.../ZipFoundation/README.md` from targets and `*.md*` files
from podspec
([https://github.com/airbnb/lottie-ios/pull/2057](https://togithub.com/airbnb/lottie-ios/pull/2057))\*
- Fix issue where layers with negative X scale values could be pixelated
([https://github.com/airbnb/lottie-ios/pull/2067](https://togithub.com/airbnb/lottie-ios/pull/2067))
- Fix warnings when building with Swift 5.9
([https://github.com/airbnb/lottie-ios/pull/2072](https://togithub.com/airbnb/lottie-ios/pull/2072))
- Restructure `ValueProviderStore` to not accumulate multiple values for
the same key
([https://github.com/airbnb/lottie-ios/pull/2082](https://togithub.com/airbnb/lottie-ios/pull/2082))
- Disable bitcode when building XCFramework
([https://github.com/airbnb/lottie-ios/pull/2121](https://togithub.com/airbnb/lottie-ios/pull/2121))
- Fix unhandled file warning when building with SPM
([https://github.com/airbnb/lottie-ios/pull/213](https://togithub.com/airbnb/lottie-ios/pull/2132))
- Fix support for customizing color of `SolidLayer` using
`ColorValueProvider`
([https://github.com/airbnb/lottie-ios/pull/2154](https://togithub.com/airbnb/lottie-ios/pull/2154))
- Fix issue where shape items could be unexpectedly ignored
([https://github.com/airbnb/lottie-ios/pull/2156](https://togithub.com/airbnb/lottie-ios/pull/2156))
- Fix issue where skew keyframes would unexpectedly not animate
([https://github.com/airbnb/lottie-ios/pull/2157](https://togithub.com/airbnb/lottie-ios/pull/2157))
- Fix issue where value providers could be ignored when falling back to
main thread rendering engine
([https://github.com/airbnb/lottie-ios/pull/2164](https://togithub.com/airbnb/lottie-ios/pull/2164))

Thanks to everyone who contributed to this release!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants