Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationTextProvider should provide the full keypath #1588

Closed
5 of 10 tasks
marcelofabri opened this issue May 11, 2022 · 0 comments · Fixed by #2183
Closed
5 of 10 tasks

AnimationTextProvider should provide the full keypath #1588

marcelofabri opened this issue May 11, 2022 · 0 comments · Fixed by #2183
Labels
enhancement Feature Request help wanted

Comments

@marcelofabri
Copy link
Contributor

Check these before submitting:

  • The issue doesn't involve an Unsupported Feature
  • This issue isn't related to another open issue

This issue is a:

  • Non-Crashing Bug (Visual or otherwise)
  • Crashing Bug
  • Feature Request
  • Regression (Something that once worked, but doesn't work anymore)

Which Version of Lottie are you using?

Lottie 3.0

What Platform are you on?

  • MacOS
  • iOS

What Language are you in?

  • Swift
  • Objective-C

Expected Behavior

AnimationTextProvider should provide the full keypath. IMO we should remove/deprecate the existing method and add a new one that provides the full keypath instead.

Actual Behavior

AnimationTextProvider calls textFor(keypathName:sourceText:) with only the last component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature Request help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update text provider API to use full AnimationKeypath values airbnb/lottie-ios
2 participants
@marcelofabri @calda