Define a max line length of 100 characters #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,8 @@ module.exports = { | |||
| 'lines-around-comment': 0, | |||
| // disallow mixed 'LF' and 'CRLF' as linebreaks | |||
| 'linebreak-style': 0, | |||
| // specify the maximum length of a line in your program | |||
There was a problem hiding this comment.
can you add https://github.com/eslint/eslint/blob/master/docs/rules/max-len.md in a comment?
|
This LGTM, pending comments. I'd be fine with it either in its own section, or in the whitespace section. |
chrisngobanh
added a commit
to chrisngobanh/javascript
that referenced
this pull request
Dec 24, 2015
[eslint] Add comment above `max-len` rule with link to its docs [eslint] Change tab width for `max-len` rule from 4 to 2 [eslint] Replace double quotes around `max-len` with single quotes [eslint] Use object form of `max-len` and include all of the options
I moved the rule from legacy.js to style.js and enabled it
[eslint] Add comment above `max-len` rule with link to its docs [eslint] Change tab width for `max-len` rule from 4 to 2 [eslint] Replace double quotes around `max-len` with single quotes [eslint] Use object form of `max-len` and include all of the options
chrisngobanh
force-pushed
the
max-len
branch
from
5fe80f9 to
e2e4724
Compare
|
@ljharb done! I also rebased |
ljharb
added a commit
that referenced
this pull request
Dec 24, 2015
[eslint config] [breaking] Define a max line length of 100 characters
|
This rule definition results in an error: The current definition is valid only in [email protected], but the package has a dependency on [email protected] which requires a different format. |
|
Oops! 2.x isn't released yet, so we should fix that. Luckily, it hasn't yet been released in |
dustinmartin
pushed a commit
to dustinmartin/javascript
that referenced
this pull request
Jan 4, 2016
[eslint] Add comment above `max-len` rule with link to its docs [eslint] Change tab width for `max-len` rule from 4 to 2 [eslint] Replace double quotes around `max-len` with single quotes [eslint] Use object form of `max-len` and include all of the options
Closed
gilbox
pushed a commit
to gilbox/javascript
that referenced
this pull request
Mar 21, 2016
[eslint] Add comment above `max-len` rule with link to its docs [eslint] Change tab width for `max-len` rule from 4 to 2 [eslint] Replace double quotes around `max-len` with single quotes [eslint] Use object form of `max-len` and include all of the options
jaylaw81
pushed a commit
to appirio-digital/ads-best-practices
that referenced
this pull request
Sep 19, 2017
[eslint] Add comment above `max-len` rule with link to its docs [eslint] Change tab width for `max-len` rule from 4 to 2 [eslint] Replace double quotes around `max-len` with single quotes [eslint] Use object form of `max-len` and include all of the options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over #510
Addresses #509
This PR adds section 18.12, which defines a limit for the length of a line to be 100 characters (including whitespace). This number was agreed upon in #510 and is also the line length defined in the Ruby style guide.
I enabled ESLint rule max-len to enforce this, as well as updated
.jshintrc.I also updated section 6.2 to recognize the newly defined line length.
Something to discuss: I put this new rule in the Whitespace section (18), but should it have its own section?
The Ruby style guide has it in its section, separate from the Whitespace section.