update best-practices config to prevent parameter object manipulation #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added good/bad examples of parameter mutation to the readme
trshafer
force-pushed
the
no-param-reassign-with-props
branch
from
b20f0b5 to
2589c67
Compare
|
just force pushed over my previous commit to change the |
|
|
||
| ```javascript | ||
| // bad | ||
| function f(a){ |
There was a problem hiding this comment.
please change ){ to ) { throughout
add link to no-param-reassign rule documentation
|
Updated the examples and rules. I can squash the commits when ready. |
| // bad | ||
| function f1(a) { | ||
| a = 1; | ||
| } |
ljharb
added a commit
that referenced
this pull request
Dec 17, 2015
[eslint config] [breaking] update best-practices config to prevent parameter object manipulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added good/bad examples of parameter mutation to the readme
addresses #626