add missing rules from eslint-plugin-react (enforcing where necessary )

[tikotzky]

Adds all missing rules from eslint-plugin-react.

Enforces react/jsx-closing-bracket-location and react/jsx-indent-props to match react style guide.

[ljharb]

does this take any configuration? even if disabled, it's useful documentation to include the default options imo (same on every rule you've added)

[tikotzky]

yes it does take a config...
I'll add the default config to all that have a config

[tikotzky]

just to clarify would you want it to look like this?

'react/forbid-prop-types': [0, {forbid: ['any', 'array', 'object']}]

[tikotzky]

or would you rather me add a link pointing to the docs by each config, like this.

    // Forbid certain propTypes (any, array, object)
    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md
    'react/forbid-prop-types': 0,

[ljharb]

I think both would be ideal - the link if people want to click through, but the default config for minimal diffs if we want to override the defaults.

[tikotzky]

Existing disabled rules don't have the default config.
Is that something you would want added everywhere?

One issue I see with that is that if the default config were to change we would out of date.

[ljharb]

Ideally yes - that's exactly the problem. I don't really care what the defaults are (now, or later) - I only care what style we want to encourage.

[tikotzky]

But what about rules that are disabled? What's the reason to include the default config there?

If someone is going to override they'll probably be looking at the docs anyway to see which config they would want to select when enabling.

[ljharb]

Because we may want to enable the rules later without having to look up the configuration from the docs :-)

[tikotzky]

I'll start by making sure each rule that is enabled specifies a config (if it has one)

I'll update the PR late tomorrow.

[tikotzky]

@ljharb I added configs for all active rules.

I also added a link to the rule docs above all the rules, I started adding by each rule but it was looking pretty messy.

I'm gonna continue adding configs to the other disabled rules.
Please let me know if you have any feedback, Thanks.

[ljharb]

Thanks! I'd like a few more contributors to take a look before merging it, but this LGTM.

[tikotzky]

ok great, let me know if you want me to change anything or squash.

[ljharb]

@tikotzky could you rebase, and also add links to the rule configs in comments above the rules? Thanks!

[ljharb]

@tikotzky oops, i just merged another react-related PR and there's conflicts again :-/ once more?

[tikotzky]

ok rebased. now to add the links...

[tikotzky]

I added links to all rules that were missing.

It seems like there has been some more rules added since this PR was originally created i'll go ahead and add those rules too.

[tikotzky]

@ljharb should be good to go now.
Let me know if you want me to squash or make any other changes.

[ljharb]

Sure, let's squash this down to one or two atomic commits, and let's merge it!

[tikotzky]

ok squashed. should be good to go 😄