Fix ID selectors #670
Merged
Fix ID selectors #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2016
|
LGTM |
blainekasten
approved these changes
Nov 9, 2016
ljharb
force-pushed
the
fix_id_selectors
branch
from
db37324 to
d3af3dc
Compare
ljharb
added a commit
that referenced
this pull request
Nov 10, 2016
[Fix] `mount`/`shallow`: fix ID selectors Fixes #495.
ljharb
added a commit
that referenced
this pull request
Nov 10, 2016
[Fix] `mount`/`shallow`: fix ID selectors Fixes #495.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the unintentional breaking change in 2.4.x (and 2.5.x), by committing horrible sins with regular expressions. This also does not revert the new behavior added in 2.4.x (that caused the breakage).
We desperately need to replace this with a proper CSS parser, but this should suffice for now.
Once merged, I'll also backport this to the 2.4.x line (and 2.5.x if master already has some semver-minor stuff).