Add .slice() method for ShallowWrapper and ReactWrapper #661
Conversation
| #### Arguments | ||
|
|
||
| 1. `begin` (`Number` [optional]): Zero-based index from which to slice (defaults to `0`). | ||
| 2. `end` (`Number` [optional]): Zero-based index at which to end slicing (defaults to `length`). |
There was a problem hiding this comment.
this isn't entirely how slice works - slice supports negative indexes as well. https://tc39.github.io/ecma262/#sec-array.prototype.slice has language that might be helpful.
Also, "index" implies "zero-based" - it's zero-based in virtually every language.
There was a problem hiding this comment.
(also, please use 1. for every item in any numbered list, so that reordering doesn't require renumbering)
| #### Arguments | ||
|
|
||
| 1. `begin` (`Number` [optional]): Zero-based index from which to slice (defaults to `0`). | ||
| 2. `end` (`Number` [optional]): Zero-based index at which to end slicing (defaults to `length`). |
There was a problem hiding this comment.
same changes here.
(also, please use 1. for every item in any numbered list, so that reordering doesn't require renumbering)
|
@nhardy this does need a rebase on latest master, though, if you don't mind :-) |
|
This looks great! Thanks @nhardy ! |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
52cfb83 to
583c04c
Compare
|
LGTM! @ljharb looks like CI is hanging, can you restart the job? |
|
i rebased it for the OP; travis-ci is having trouble; i've got the merge queued to go on my command line once it passes. |
|
Meant to get to rebasing the PR today, but thanks for taking care of that :) |
Adds a new
.slice()method forShallowWrapperandReactWrapperwith functionality likeArray#slice.Closes #647.