Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shim to detect constructor function name. #659

Merged
merged 1 commit into from
Nov 7, 2016
Merged

Use shim to detect constructor function name. #659

merged 1 commit into from
Nov 7, 2016
+11 −5

Conversation

dompuiu
Copy link
Contributor

@dompuiu dompuiu commented Nov 5, 2016

This will make enzyme detect stateless components correctly also in
Internet Explorer.

@dompuiu @ljharb
[Fix] Use shim to detect constructor function name.
33b5680 
This will make enzyme detect stateless components correctly also in Internet Explorer.
@dompuiu
Copy link
Contributor Author

dompuiu commented Nov 5, 2016

This is a tentative to fix #658.

ljharb
ljharb requested changes Nov 5, 2016
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, but could you also update every other instance in the codebase of calling .name on a function? That way, the examples will be clear, and all of the IE 9 - 11 bugs will be fixed at once.

@ljharb ljharb self-assigned this Nov 5, 2016
@dompuiu
Copy link
Contributor Author

dompuiu commented Nov 7, 2016

I have updated all the places where .name was used.

@ljharb ljharb merged commit 33b5680 into enzymejs:master Nov 7, 2016
@dompuiu dompuiu mentioned this pull request Nov 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

@ljharb ljharb

Labels
API: mount API: shallow semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dompuiu @ljharb