Warn if selector contains a pseudo-class #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const tokens = selector.split(containsQuotes); | ||
| for (let i = 0; i < tokens.length; i++) { | ||
| const token = tokens[i]; | ||
| if (containsColon.test(token) && i % 2 === 0) { |
There was a problem hiding this comment.
This works assuming that an attribute value doesn't contain a quote ('[data-foo="foo':bar'"]'), which seems reasonable
There was a problem hiding this comment.
seems like we could use some to do this without a loop? return tokens.some((token, i) => containsColon.test(token) && i % 2 === 0)?
Also pseudo-spelling errors
aweary
force-pushed
the
warn-for-psuedo-classes
branch
from
141f3a7 to
2d94e53
Compare
ljharb
changed the title
| @@ -187,6 +200,9 @@ export const SELECTOR = { | |||
| }; | |||
|
|
|||
| export function selectorType(selector) { | |||
| if (isPseudoClassSelector(selector)) { | |||
| throw selectorError(selector, 'pseudo-class'); | |||
There was a problem hiding this comment.
is there usually a hyphen in pseudoclass?
There was a problem hiding this comment.
It's hyphenated in the spec.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still don't support these, so we need to warn about them. Parsing this with a RegEx is really difficult so instead
isPseudoClassSelectordoes some minimal pattern matching combined with some logic to only match cases where:is not within quotes.cc @ljharb