Ensure that ShallowWrapper and ReactWrapper handle a null child correctly
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -321,7 +321,7 @@ export default class ShallowWrapper { | |||
| * @returns {CheerioWrapper} | |||
| */ | |||
| render() { | |||
| return cheerio.load(this.html()).root(); | |||
| return this.type() === null ? cheerio() : cheerio.load(this.html()).root(); | |||
There was a problem hiding this comment.
did the previous implementation of this throw an exception in this case? is cheerio() what we want to return?
There was a problem hiding this comment.
yes, previously it threw TypeError: Cannot read property 'parent' of null from inside cheerio.
cheerio() and cheerio(null) and cheerio('') all return an empty cheerio wrapper - i just chose the simplest of these
ljharb
force-pushed
the
ljharb/type_null
branch
from
face3d2 to
1e410ff
Compare
|
LGTM. |
lelandrichardson
added a commit
that referenced
this pull request
Feb 18, 2016
Ensure that `ShallowWrapper` and `ReactWrapper` handle a null child correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52 .