Add .debug() method to ReactWrapper #158
Conversation
|
|
||
| export function debugInst(inst, indentLength = 2) { | ||
| if (typeof inst === 'string' || typeof inst === 'number') return escape(inst); | ||
| if (!inst) return ''; |
There was a problem hiding this comment.
just want to confirm - these two lines will not do anything special for true, or for Symbols.
There was a problem hiding this comment.
hmm.... not that I'm aware of.
I don't actually know what calling this on <div>{true}</div> would do, but it should do whatever react itself does...
No idea how or why or what symbols would be doing getting called in this function....?
There was a problem hiding this comment.
just checked and <div>{true}</div> gets rendered as <div />
There was a problem hiding this comment.
In that case, wouldn't we want if (inst === true) return ''? or am i misunderstanding something.
what about <div>{Symbol('foo')}</div>?
There was a problem hiding this comment.
@ljharb <div>{Symbol('foo')}</div> also renderes an empty div. I think this function isn't being used exactly how you imagine it. Though i'm not sure I event 100% understand it... lol
lelandrichardson
force-pushed
the
lmr--reactwrapper-debug
branch
from
05c16c1 to
067f766
Compare
| if (isDOMComponent(publicInst)) { | ||
| const renderedChildren = renderedChildrenOfInst(inst) || childrenOfNode(currentElement); | ||
| let key; | ||
| for (key in renderedChildren) { |
There was a problem hiding this comment.
Instead of
let key;
for (key in renderedChildren) {why not
for (const key in renderedChildren) {?
Or, can we use Object.values yet?
There was a problem hiding this comment.
Or would Array.from work here? I'm not really familiar with what _renderedChildren looks like.
There was a problem hiding this comment.
Object.values might work. This ends up not being an array. Not really sure why though. A lot of this code started out from source copied from react core.
There was a problem hiding this comment.
You can pull in https://npmjs.com/object.values if you want to use it ;-)
lelandrichardson
force-pushed
the
lmr--reactwrapper-debug
branch
from
067f766 to
1c8ab61
Compare
|
👍 we can leverage it in chai-enzyme cc @ayrton |
lelandrichardson
force-pushed
the
lmr--reactwrapper-debug
branch
4 times, most recently
from
89371df to
ea4afc9
Compare
Add .debug() method to ReactWrapper
to: @lencioni @ljharb @goatslacker
Adds a debug method to the ReactWrapper. Mirrors the API and implementation of the method on ShallowWrapper.
Fixes #128