Make correct output for number children in debug #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ function propsString(node) { | |||
|
|
|||
| export function debugNode(node, indentLength = 2) { | |||
| if (!node) return ''; | |||
There was a problem hiding this comment.
While i'm looking at this, it seems like this should be
if (!node && node !== 0) return '';
Since react will stringify 0 to '0'
|
This looks good to me. Mind implementing my one comment + corresponding test for bonus points??? 😃 |
|
Thanks for contributing, btw! |
roadhump
force-pushed
the
issue/debug-number
branch
from
801bf42
to
cf4a2d6
Compare
|
@lelandrichardson Fixed issue with zero, thank you |
lelandrichardson
added a commit
that referenced
this pull request
Jan 30, 2016
Make correct output for number children in debug
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have strange
<undefined />tag instead of child of number type. This PR should fix it.